Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-14368: Default to kube-proxy health probes for Service type=LoadBalancer #72

Conversation

damdo
Copy link
Member

@damdo damdo commented Jun 7, 2023

This PR changes the default Protocol, Port and Path for Services of type=LoadBalancer kube-proxy based health probes to moving towards what is envisioned in the KEP-3836: Improve Kube-proxy ingress connectivity reliability and to fix the issues described in kubernetes-sigs#3499

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 7, 2023
@openshift-ci-robot
Copy link

@damdo: This pull request references Jira Issue OCPBUGS-14368, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR changes the default Protocol, Port and Path for Services of type=LoadBalancer kube-proxy based health probes to moving towards what is envisioned in the KEP-3836: Improve Kube-proxy ingress connectivity reliability and to fix the issues described in kubernetes-sigs#3499

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 7, 2023
@openshift-ci openshift-ci bot requested a review from sunzhaohua2 June 7, 2023 07:52
@damdo damdo force-pushed the etp-cluster-services-default-kubeproxy-probes-downstream branch from 1596e14 to 6851a5b Compare June 7, 2023 07:53
@JoelSpeed
Copy link

Commit message prefix UPSTREAM: <carry>: should refer to the upstream PR, can you please update to UPSTREAM: 3887:

Otherwise I think this is ok.

Having reviewed what's going on here, and based on my comments upstream, I think this is safe to proceed with, I don't think this will break existing users

@damdo damdo force-pushed the etp-cluster-services-default-kubeproxy-probes-downstream branch from 6851a5b to e993a71 Compare June 7, 2023 10:45
@damdo
Copy link
Member Author

damdo commented Jun 7, 2023

Ah yes, good point! Commit message updated.
Thanks @JoelSpeed

@JoelSpeed
Copy link

Ok, changes LGTM but I'd like to see how the techpreview jobs handle this, in particular a techpreview upgrade would be good to observe passing

@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2023

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@JoelSpeed
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2023
@openshift-merge-robot openshift-merge-robot merged commit ce02abc into openshift:master Jun 7, 2023
10 checks passed
@openshift-ci-robot
Copy link

@damdo: Jira Issue OCPBUGS-14368: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-14368 has been moved to the MODIFIED state.

In response to this:

This PR changes the default Protocol, Port and Path for Services of type=LoadBalancer kube-proxy based health probes to moving towards what is envisioned in the KEP-3836: Improve Kube-proxy ingress connectivity reliability and to fix the issues described in kubernetes-sigs#3499

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants