New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-14368: Default to kube-proxy health probes for Service type=LoadBalancer #72
OCPBUGS-14368: Default to kube-proxy health probes for Service type=LoadBalancer #72
Conversation
@damdo: This pull request references Jira Issue OCPBUGS-14368, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1596e14
to
6851a5b
Compare
Commit message prefix Otherwise I think this is ok. Having reviewed what's going on here, and based on my comments upstream, I think this is safe to proceed with, I don't think this will break existing users |
…LoadBalancer, externalTrafficPolicy=Cluster
6851a5b
to
e993a71
Compare
Ah yes, good point! Commit message updated. |
Ok, changes LGTM but I'd like to see how the techpreview jobs handle this, in particular a techpreview upgrade would be good to observe passing |
@damdo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@damdo: Jira Issue OCPBUGS-14368: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-14368 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR changes the default Protocol, Port and Path for Services of type=LoadBalancer kube-proxy based health probes to moving towards what is envisioned in the KEP-3836: Improve Kube-proxy ingress connectivity reliability and to fix the issues described in kubernetes-sigs#3499