New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-14368: Do not detach masters from LB when unready #76
OCPBUGS-14368: Do not detach masters from LB when unready #76
Conversation
@damdo: This pull request references Jira Issue OCPBUGS-14368, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@damdo: This pull request references Jira Issue OCPBUGS-14368, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I'd like to carry this PR without submitting it upstream. In openshift we need to make sure to improve the topology by including an improved topology for the azure load balancers, introducing a secondary load balancer backend pool for outbound traffic |
@damdo: This pull request references Jira Issue OCPBUGS-14368, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8d879a8
to
4ed4961
Compare
/test e2e-azure-ovn |
/hold |
/assign @JoelSpeed |
/retest |
@damdo: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve I'd like QE approval that this, in combination with the promotion PR to GA, openshift/cluster-config-operator#307, solves the image pull issue they've been observing, before we merge |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh I've been manually testing this and am confident it's doing what I'm expecting it to do |
@JoelSpeed: This pull request references Jira Issue OCPBUGS-14368, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
@damdo: Jira Issue OCPBUGS-14368: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-14368 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Originally the masters that would go UnReady were detached from the LoadBalancer to avoid traffic being forwarded to the pods backing the LoadBalancer's Service.
This would cause an issue on OCP because masters rely on being connected to this public LoadBalancer to retain outbound internet connection, and having an UnReady master detached may have rendered it unable to recover due to it not having access to outbound internet connection.
Now that kube-proxy based healthprobes have been/are being implemented for Services of type LoadBalancer and ETP=Cluster (downstream with #72 and upstream with kubernetes-sigs#3887)
the master detachment on Unreadiness is not necessary anymore.
As such we disabling this.
This is a fix for kubernetes-sigs#3500