Merge https://github.com/kubernetes/cloud-provider-openstack:master into master #205
Conversation
![shiftstack-merge-bot[bot]](https://avatars.githubusercontent.com/u/48560946?s=60&v=4){kind=small}
In OpenStack default AZ is called 'nova', thus device_owner is filled with 'compute:nova', and that's ok for deployments within one (default) AZ. Filtering by device_owner however, will make function getAttachedPorts to return zero ports for provided node. In this patch, filtering by device_owner is simply removed.
…ion, add more logs (kubernetes#2296) * [cinder]: avoid unnecessary memory allocation with more logs * Fix pagination parsing
This commit makes sure that in all instances of reading Nova instance ID from the `.Spec.ProviderID` field, we're using `instanceIDFromProviderID()` function which is designed for that purpose.
Matt noticed several optimizations that can be done in `applyNodeSecurityGroupIDForLB()` function. I added a few more refactorings. In particular: * We don't need to lookup servers by name as we have `.spec.providerID` in the nodes passed to the function. * We don't need to lookup servers at all when we have the ID, we can fetch ports by `deviceID`. * This means we don't need a Nova client in the LB instance anymore. * `slices.Contains()` from K8s utils can be used to check if SG is in the list. * It's better to tag the port with SG before we actually apply it. This will protect us from situations when the SG is applied, but tagging the port failed and now when deleting the SG CPO would be unable to find the port and therefore delete the SG.
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @shiftstack-merge-bot[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
@shiftstack-merge-bot[bot]: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, shiftstack-merge-bot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
No description provided.