Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge https://github.com/kubernetes/cloud-provider-openstack:master into master #205

Merged
merged 6 commits into from Jul 20, 2023

Commits on Jul 18, 2023

  1. Remove filtering by device_owner. (kubernetes#2304)

    In OpenStack default AZ is called 'nova', thus device_owner is filled
    with 'compute:nova', and that's ok for deployments within one (default)
    AZ.
    
    Filtering by device_owner however, will make function getAttachedPorts
    to return zero ports for provided node. In this patch, filtering by
    device_owner is simply removed.
    gryf committed Jul 18, 2023
    Copy the full SHA
    a2c86f9 View commit details
    Browse the repository at this point in the history
  2. [cinder-csi-plugin]: fix pagination, avoid unnecessary memory allocat…

    …ion, add more logs (kubernetes#2296)
    
    * [cinder]: avoid unnecessary memory allocation with more logs
    
    * Fix pagination parsing
    kayrus committed Jul 18, 2023
    Copy the full SHA
    95dc81c View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Use instanceIDFromProviderID() function (kubernetes#2302)

    This commit makes sure that in all instances of reading Nova instance ID
    from the `.Spec.ProviderID` field, we're using
    `instanceIDFromProviderID()` function which is designed for that
    purpose.
    dulek committed Jul 19, 2023
    Copy the full SHA
    0514aba View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Copy the full SHA
    64b382f View commit details
    Browse the repository at this point in the history
  2. Optimize applyNodeSecurityGroupIDForLB() (kubernetes#2293)

    Matt noticed several optimizations that can be done in
    `applyNodeSecurityGroupIDForLB()` function. I added a few more
    refactorings. In particular:
    
    * We don't need to lookup servers by name as we have `.spec.providerID`
      in the nodes passed to the function.
    * We don't need to lookup servers at all when we have the ID, we can
      fetch ports by `deviceID`.
    * This means we don't need a Nova client in the LB instance anymore.
    * `slices.Contains()` from K8s utils can be used to check if SG is in
      the list.
    * It's better to tag the port with SG before we actually apply it. This
      will protect us from situations when the SG is applied, but tagging
      the port failed and now when deleting the SG CPO would be unable to
      find the port and therefore delete the SG.
    dulek committed Jul 20, 2023
    Copy the full SHA
    b229f84 View commit details
    Browse the repository at this point in the history
  3. Merge https://github.com/kubernetes/cloud-provider-openstack:master i…

    …nto master
    shiftstack-merge-bot committed Jul 20, 2023
    Copy the full SHA
    5a3888f View commit details
    Browse the repository at this point in the history