Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1820238: Fetch latest changes from upstream #38

Merged
merged 23 commits into from Nov 26, 2020

Conversation

Fedosin
Copy link

@Fedosin Fedosin commented Nov 26, 2020

This patch fetches all latest changes from upstream.
90378cf is important to fix the issue with remaining manila shares after cluster deletion.

oz123 and others added 23 commits October 6, 2020 22:56
This commit updates the CLI flags used to launch the controller manager.
The usage of `address` is deprecated. Hence, this commit updates the
flags to `bind-address` kubernetes#1258.
…ubernetes#1267)

* [cinder-csi-plugin]: set cinder CSI sidecar timeouts

* Update manifests/cinder-csi-plugin/cinder-csi-controllerplugin.yaml

Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>

* Add cinder CSI timeouts to helm-charts

Co-authored-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
* [cinder-csi-plugin] Improve docs [Part2]

This splits the docs to diff files for better readability

* Update csc-tool.md

* Update using-cinder-csi-plugin.md
Also ,run format because it will do grammar check as well
Signed-off-by: Sean Schneeweiss <sean.schneeweiss@daimler.com>
* Fix whitespaces and invalit dot

* fix indentation and add nindent
…netes#1291)

* added appendShareMetadata volume parameter

* set share metadata from shareOpts when creating a new share

* updated docs

* docs: amended field description for appendShareMetadata
…ting (kubernetes#1272)

* Add error handling for list fucntions before creating

* fix comments
…sword" options (kubernetes#1311)

* [occm]: add support for "tls-insecure" option

* Cover trustee-id and trustee-password in gcfg
* [cinder-csi-plugin] support ignore-volume-az

* Update using-cinder-csi-plugin.md
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Nov 26, 2020
@openshift-ci-robot
Copy link

@Fedosin: This pull request references Bugzilla bug 1820238, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1820238: Fetch latest changes from upstream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 26, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2020
@EmilienM
Copy link
Member

don't we want to run e2e-openstack job?

@Fedosin
Copy link
Author

Fedosin commented Nov 26, 2020

/test e2e-openstack

@openshift-ci-robot
Copy link

@Fedosin: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test images
  • /test unit

Use /test all to run all jobs.

In response to this:

/test e2e-openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Fedosin
Copy link
Author

Fedosin commented Nov 26, 2020

oh... looks like we don't have any :(

@mandre
Copy link
Member

mandre commented Nov 26, 2020

This repo is used for cinder csi and manila csi, and in the future for the external cloud provider.
The basic e2e-openstack parallel test suite woudn't test any of the changes introduced in this patch, we would need to run the CSI tests for this. Although I'm not super happy with the situation, we don't have other choices than blindly accept these changes and hope they don't break cinder CSI or manila CSI.

@EmilienM
Copy link
Member

/lgtm
/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, Fedosin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit fb3975d into openshift:master Nov 26, 2020
@openshift-ci-robot
Copy link

@Fedosin: All pull requests linked via external trackers have merged:

Bugzilla bug 1820238 has been moved to the MODIFIED state.

In response to this:

Bug 1820238: Fetch latest changes from upstream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet