New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1874618: fix unit tests so we can add a CI job #111
Bug 1874618: fix unit tests so we can add a CI job #111
Conversation
If we can't link the machine to the host by updating its annotation, wrap the error before returning it so the caller can report more details. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
The client requires resources to have valid names and namespaces before the Update() method can be called, so ensure all of the test cases construct the resource with valid names. Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann: This pull request references Bugzilla bug 1874618, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@hardys: This pull request references Bugzilla bug 1874618, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, hardys The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dhellmann: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1874618 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Initial PR on v1alpha2 migration (inc. openshift#111)
🏃 Add fmuyassarov, furkatgofurov7, jan-est as reviewer
Fix some unit test failures that slipped past because we are not running
the unit tests in CI.