Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1874618: cluster-api-provider-baremetal: add unit test job #11458

Merged
merged 1 commit into from Sep 14, 2020
Merged

Bug 1874618: cluster-api-provider-baremetal: add unit test job #11458

merged 1 commit into from Sep 14, 2020

Conversation

dhellmann
Copy link
Contributor

We were running an end-to-end test job, but not the unit tests.

/assign @zaneb

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2020
@zaneb
Copy link
Member

zaneb commented Sep 1, 2020 

go run vendor/sigs.k8s.io/controller-tools/cmd/controller-gen/main.go crd paths=./pkg/apis/... output:crd:dir=./config/crds/
/bin/sh: kustomize: command not found

sigh

@dhellmann
Copy link
Contributor Author

See openshift/cluster-api-provider-baremetal#107

@dhellmann dhellmann mentioned this pull request Sep 1, 2020
Merged
@dhellmann dhellmann changed the title cluster-api-provider-baremetal: add unit test job Bug 1874618: cluster-api-provider-baremetal: add unit test job Sep 1, 2020
@dhellmann
Copy link
Contributor Author

/bugzilla refresh

@dhellmann dhellmann mentioned this pull request Sep 3, 2020
Merged
@dhellmann
cluster-api-provider-baremetal: add unit test job
ea98c85 
We were running an end-to-end test job, but not the unit tests.

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann
Copy link
Contributor Author

/retest

@dhellmann
Copy link
Contributor Author

Waiting for openshift/cluster-api-provider-baremetal#108

@dhellmann
Copy link
Contributor Author

/retest

@dhellmann
Copy link
Contributor Author

Now we need openshift/cluster-api-provider-baremetal#111

@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 14, 2020
Merged
@hardys
Copy link
Contributor

hardys commented Sep 14, 2020

Now we need openshift/cluster-api-provider-baremetal#111

Now merged

/retest

@hardys
Copy link
Contributor

hardys commented Sep 14, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 709c883 into openshift:master Sep 14, 2020
@openshift-ci-robot
Copy link
Contributor

@dhellmann: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-api-provider-baremetal-master.yaml using file ci-operator/config/openshift/cluster-api-provider-baremetal/openshift-cluster-api-provider-baremetal-master.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cluster-api-provider-baremetal-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-baremetal/openshift-cluster-api-provider-baremetal-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-api-provider-baremetal-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-baremetal/openshift-cluster-api-provider-baremetal-master-presubmits.yaml

In response to this:

We were running an end-to-end test job, but not the unit tests.

/assign @zaneb

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@dhellmann: All pull requests linked via external trackers have merged:

Bugzilla bug 1874618 has been moved to the MODIFIED state.

In response to this:

Bug 1874618: cluster-api-provider-baremetal: add unit test job

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardys hardys Awaiting requested review from hardys

@zaneb zaneb Awaiting requested review from zaneb

Assignees

@zaneb zaneb

@hardys hardys

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
5 participants
@dhellmann @zaneb @hardys @openshift-ci-robot @openshift-merge-robot