Bug 1845607:Add generate-check Makefile target to check the generated code and CRDs #112
Conversation
|
/assign @dhellmann |
|
/approve |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, kirankt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-metal-ipi |
|
/retitle Bug 1845607:Add generate-check Makefile target to check the generated code and CRDs |
openshift-ci-robot
changed the title
openshift-ci-robot
added
bugzilla/severity-low
|
@kirankt: This pull request references Bugzilla bug 1845607, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kirankt: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1845607 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Initial PR on v1alpha2 migration (inc. openshift#111)
This PR reworks the Makefile to add support for code and CRD generation checking. It also streamlines some of the Makefile targets e.g kustomized output is directly applied to install rather than just generate the yaml.
The controller-gen CRD generation annotation is also removed as part of manifest generation.