Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1828457: bump(*): vendor update #282

Merged
merged 4 commits into from Apr 28, 2020

Conversation

mfojtik
Copy link
Member

@mfojtik mfojtik commented Apr 27, 2020

@mfojtik
Copy link
Member Author

mfojtik commented Apr 27, 2020

@marun @stlaz can you review the react changes?

@stlaz
Copy link
Member

stlaz commented Apr 27, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 27, 2020
@stlaz
Copy link
Member

stlaz commented Apr 27, 2020

note that the deployment change was already done in #272 but did not have a valid BZ attached, similarly to this PR...

@stlaz
Copy link
Member

stlaz commented Apr 27, 2020

/lgtm cancel
I was not paying enough attention to the changes, please rebase on top of the mentioned PR

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 27, 2020
@mfojtik mfojtik changed the title bump(*): vendor update Bug 1828457: bump(*): vendor update Apr 27, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Apr 27, 2020
@openshift-ci-robot
Copy link
Contributor

@mfojtik: This pull request references Bugzilla bug 1828457, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1828457: bump(*): vendor update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* openshift/api@27f27266: Add Route for consoles custom hostname
* openshift/api@1f595939: Add VirtualHostedStyle to S3 configuration options
* openshift/api@366fdb33: Adds WildcardPolicy field to IngressController API
* openshift/api@d363d3fc: Update optional tags where needed
* openshift/api@710ab014: Fix the default for Authentication.ServiceAccountIssuer
* openshift/api@556c4b92: make update
* openshift/api@27622da9: Replace library-go references with build-machinery-go for CRD gen readme
* openshift/api@722c7a62: enable priority and fairness for kube-apiserver
* openshift/api@f5df9218: Builds: Make a bunch of fields omitempty
* openshift/api@6c25f0fd: config/v1/types_infrastructure.go: add service endpoints to aws platform spec and status
* openshift/api@1fc310b2: operator/ingress: Add logging API
* openshift/api@2dadc742: config/v1/types_infrastructure.go: update the cloudConfig spec to define the generated one's location
* openshift/api@b7121e12: config/v1: add status subresource for infrstrastructure
* openshift/api@0f7ea195: bump to kube v1.18.2
* openshift/api@9e7957d9: bump(build-machinery-go)
* openshift/build-machinery-go@8c085b90: Switch to go-bindata/go-bindata for consistency with upstream
* openshift/library-go@ddf47476: add WithCustomInstaller method to Builder interface
* openshift/library-go@4c47103d: Fix SA token sync
* openshift/library-go@a39bf282: fileObserver: detect file existence when adding reactor
* openshift/library-go@b833546a: Fix serving-certs race for controller's NewCommand*
* openshift/library-go@609e1511: Fix ApplySecret for type changes
* openshift/library-go@e43e3d51: Fix error handling of status controller
* openshift/library-go@114736d4: cmdbuilder: add WithVersion() that reports version metrics of binary
* openshift/library-go@eca66601: cmd: add WithVersion to StartController
* openshift/library-go@a20f1d95: Fix Apply{Deployment,Deployment} to copy input before mutatating
* openshift/library-go@42af5458: Update ApplyDeployment to rely on a hash of the spec
* openshift/library-go@3b4f06f8: Update ApplyDaemonSet to rely on a hash of the spec
* openshift/library-go@82e3f523: Bug 1826259: fix ingress CA cert location
* openshift/library-go@c1de486c: Remove bitbucket.org/ww/goautoneg dependency
* openshift/library-go@4960ca0c: Bump to kube v1.18.2
* openshift/library-go@d14c8892: version: make sure to always have namespace when reporting version
* openshift/library-go@556325fc: resourcesynccontroller: fix race in unit test
* openshift/library-go@b3ec7d2d: vendor: Consolidate onto github.com/munnerz/goautoneg
* openshift/library-go@7813cff0: staticpodstate: improve condition and event messages
* openshift/library-go@efe996af: bump(api,build-machinery-go)
* openshift/library-go@029d40b0: Switch go go-bindata/go-bindata for consistency with upstream
* openshift/library-go@53b922b0: make update
* openshift/library-go@e07b1834: Update featuregate unit test to include APIPriorityAndFairness=true
* openshift/library-go@209722f0: events: wire graceful broadcaster shutdown
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2020
marun and others added 2 commits April 28, 2020 09:26
The new method hashes the spec of the deployment which removes the
need for considering generation or forcing rollout.
@stlaz
Copy link
Member

stlaz commented Apr 28, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a5abd6c into openshift:master Apr 28, 2020
@openshift-ci-robot
Copy link
Contributor

@mfojtik: Some pull requests linked via external trackers have merged: openshift/cluster-authentication-operator#282, openshift/cluster-config-operator#129, openshift/cluster-etcd-operator#323, openshift/cluster-kube-apiserver-operator#837. The following pull requests linked via external trackers have not merged:

In response to this:

Bug 1828457: bump(*): vendor update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants