Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1828457: bump(*): vendor update #118

Merged
merged 3 commits into from
Apr 28, 2020
Merged

Bug 1828457: bump(*): vendor update #118

merged 3 commits into from
Apr 28, 2020

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Apr 27, 2020

@mfojtik
bump(*): vendor update
fe69226 
* openshift/api@9e7957d9: bump(build-machinery-go)
* openshift/build-machinery-go@8c085b90: Switch to go-bindata/go-bindata for consistency with upstream
* openshift/library-go@e43e3d51: Fix error handling of status controller
* openshift/library-go@efe996af: bump(api,build-machinery-go)
* openshift/library-go@029d40b0: Switch go go-bindata/go-bindata for consistency with upstream
* openshift/library-go@53b922b0: make update
* openshift/library-go@e07b1834: Update featuregate unit test to include APIPriorityAndFairness=true
* openshift/library-go@209722f0: events: wire graceful broadcaster shutdown
@mfojtik
react to library-go changes
63b4e22
@mfojtik mfojtik changed the title bump(*): vendor update Bug 1828457: bump(*): vendor update Apr 27, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Apr 27, 2020
@openshift-ci-robot
Copy link
Contributor

@mfojtik: This pull request references Bugzilla bug 1828457, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1828457: bump(*): vendor update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 27, 2020
@mfojtik
Copy link
Contributor Author

mfojtik commented Apr 27, 2020

/retest

2 similar comments
@marun
Copy link
Contributor

marun commented Apr 28, 2020

/retest

@marun
Copy link
Contributor

marun commented Apr 28, 2020

/retest

@marun
Copy link
Contributor

marun commented Apr 28, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit a66742c into openshift:master Apr 28, 2020
@openshift-ci-robot
Copy link
Contributor

@mfojtik: Some pull requests linked via external trackers have merged: . The following pull requests linked via external trackers have not merged:

In response to this:

Bug 1828457: bump(*): vendor update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marun marun Awaiting requested review from marun

@stlaz stlaz Awaiting requested review from stlaz

Assignees

@marun marun

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mfojtik @openshift-ci-robot @marun @openshift-merge-robot