Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1915473: Annotate manifests for single-node-developer cluster profile #65

Merged
merged 1 commit into from Jan 15, 2021
Merged

Bug 1915473: Annotate manifests for single-node-developer cluster profile #65

merged 1 commit into from Jan 15, 2021

Conversation

guillaumerose
Copy link
Contributor

This implements phase 1 of openshift/enhancements#482

bertinatto
bertinatto reviewed Dec 4, 2020
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guillaumerose: apologies for the late review.

Could you please rebase your PR and include the files introduced in #62?

@guillaumerose
Copy link
Contributor Author

@bertinatto done thanks!

@bertinatto
Copy link
Member

@bertinatto done thanks!

@guillaumerose I don't see the annotation in manifests/09_webhook_config.yaml for example. Isn't it necessary there?

@guillaumerose
Copy link
Contributor Author

Thanks I didn't see the new file. I included all files now.

@bertinatto
Copy link
Member

/retest

2 similar comments
@cfergeau
Copy link

cfergeau commented Dec 7, 2020

/retest

@rkukura
Copy link

rkukura commented Jan 4, 2021

/retest

bertinatto
bertinatto reviewed Jan 5, 2021
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, guillaumerose

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 5, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

13 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2021
@guillaumerose
Copy link
Contributor Author

rebased

@guillaumerose guillaumerose changed the title Annotate manifests for single-node-developer cluster profile Bug 1915473: Annotate manifests for single-node-developer cluster profile Jan 12, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jan 12, 2021
@openshift-ci-robot
Copy link
Contributor

@guillaumerose: This pull request references Bugzilla bug 1915473, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1915473: Annotate manifests for single-node-developer cluster profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 12, 2021
@cfergeau
Copy link

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels Jan 13, 2021
@openshift-ci-robot
Copy link
Contributor

@cfergeau: This pull request references Bugzilla bug 1915473, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cfergeau
Copy link

The ci/prow/verify failure should be fixable with make update-bindata

@openshift-ci-robot openshift-ci-robot mentioned this pull request Jan 14, 2021
Merged
@cfergeau
Copy link

/retest

@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2021
@cfergeau
Copy link

/retest

@openshift-merge-robot openshift-merge-robot merged commit 568c9cd into openshift:master Jan 15, 2021
@openshift-ci-robot
Copy link
Contributor

@guillaumerose: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1915473 has not been moved to the MODIFIED state.

In response to this:

Bug 1915473: Annotate manifests for single-node-developer cluster profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jan 15, 2021
Merged
Merged
Merged
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request Feb 19, 2021
Merged
5 tasks
@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@bertinatto bertinatto

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@guillaumerose @bertinatto @cfergeau @rkukura @openshift-ci-robot @openshift-bot @jsafrane @openshift-merge-robot