Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1915473: Annotate manifests for single-node-developer cluster profile #187

Merged

Conversation

cfergeau
Copy link
Contributor

@cfergeau cfergeau commented Dec 1, 2020

This partially implements phase 1 of https://github.com/openshift/enhancements#482
and does not change behavior. Initially, all cluster-openshift-controller-manager-operator
manifests are included in the single-node-developer cluster profile.
Follow-on PRs may exclude any of these that are not needed in the
profile.

This partially implements phase 1 of https://github.com/openshift/enhancements#482
and does not change behavior. Initially, all cluster-openshift-controller-manager-operator
manifests are included in the single-node-developer cluster profile.
Follow-on PRs may exclude any of these that are not needed in the
profile.
@cfergeau
Copy link
Contributor Author

cfergeau commented Dec 2, 2020

/retest

@cfergeau cfergeau changed the title Annotate manifests for single-node-developer cluster profile Bug 1915473: Annotate manifests for single-node-developer cluster profile Jan 12, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jan 12, 2021
@openshift-ci-robot
Copy link
Contributor

@cfergeau: This pull request references Bugzilla bug 1915473, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1915473: Annotate manifests for single-node-developer cluster profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 12, 2021
@cfergeau
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jan 13, 2021
@openshift-ci-robot
Copy link
Contributor

@cfergeau: This pull request references Bugzilla bug 1915473, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Jan 13, 2021
@cfergeau
Copy link
Contributor Author

Could this get a review?

@cfergeau
Copy link
Contributor Author

@mfojtik @gabemontero could you take a look?

@gabemontero
Copy link
Contributor

@mfojtik @gabemontero could you take a look?

I don't have approve powers for this repo, but I'll

/lgtm

/assign @mfojtik
/assign @soltysh

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2021
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@cfergeau
Copy link
Contributor Author

cfergeau commented Jan 20, 2021

Any idea why the bot did not pick up the /approve?

@soltysh
Copy link
Member

soltysh commented Jan 20, 2021

Any idea why the bot did not pick up the /approve?

GH had issues yesterday, probably it missed it.
/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, gabemontero, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2021
@cfergeau
Copy link
Contributor Author

Any idea why the bot did not pick up the /approve?

GH had issues yesterday, probably it missed it.
/approve

It picked it up now, thanks!

@cfergeau
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 9b4fcbc into openshift:master Jan 20, 2021
@openshift-ci-robot
Copy link
Contributor

@cfergeau: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1915473 has not been moved to the MODIFIED state.

In response to this:

Bug 1915473: Annotate manifests for single-node-developer cluster profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants