Bug 1915473: Annotate manifests for single-node-developer cluster profile #188
Conversation
This partially implements phase 1 of https://github.com/openshift/enhancements#482 and does not change behavior. Initially, all cluster-autoscaler-operator manifests are included in the single-node-developer cluster profile. Follow-on PRs may exclude any of these that are not needed in the profile.
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@cfergeau: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
hey, i just took a quick look at this and it looks ok to me but i want to read up on the enhancement a little more. |
There was a problem hiding this comment.
after reading through the enhancement, i do not think we should be including the autoscaler components in the single node profile.
firstly, given the goals described in that doc the autoscaler should not be used with the single node profile.
secondly, the machine-api-operator is called out specifically as not being included and the autoscaler would require the machine-api to operate.
i think we should mark this component as false, or exclude it from inclusion in the single node profile. it wasn't clear to me from reading the enhancement if we should use the include.release.openshift.io/single-node-developer: "false" annotation at this time or if we should just not add it to this component.
|
For now, we are including everything in the single-node-developer profile, as before disabling components, we need to make sure nothing requires it during the installation. But I agree that eventually it's likely we'll disable this. |
|
thanks for the clarification @cfergeau |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
cfergeau
changed the title
openshift-ci-robot
added
bugzilla/severity-unspecified
|
@cfergeau: This pull request references Bugzilla bug 1915473, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/severity-medium
|
@cfergeau: This pull request references Bugzilla bug 1915473, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can you also add a /lgtm? Or is this going to be done by a second reviewer? |
|
i think it's best to get a second reviewer, cc @alexander-demichev or @JoelSpeed this is similar to the mao changes for single-node-developer stuff. |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
@cfergeau: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1915473 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This partially implements phase 1 of https://github.com/openshift/enhancements#482
and does not change behavior. Initially, all cluster-autoscaler-operator
manifests are included in the single-node-developer cluster profile.
Follow-on PRs may exclude any of these that are not needed in the
profile.