Bug 1880148: Set DNS DaemonSet's maxUnavailable value to 10%

[Miciah]

Enable rolling updates to scale linearly with the cluster number of nodes by setting the maxUnavailable value to a percentage instead of the default value of 1.

• assets/dns/daemonset.yaml: Set maxUnavailable to 10%.
• pkg/manifests/bindata.go: Regenerate.
• pkg/operator/controller/controller_dns_daemonset.go (daemonsetConfigChanged): Check if the update strategy changed and update it if it did.
• pkg/operator/controller/controller_dns_daemonset_test.go (TestDaemonsetConfigChanged): Add test case to verify that daemonsetConfigChanged detects updates to spec.updateStrategy.
• pkg/operator/controller/dns_status.go (computeDNSDegradedCondition): Handle percentages values for maxUnavailable.
• pkg/operator/controller/dns_status_test.go (TestComputeDNSDegradedCondition): New test.

[openshift-ci-robot]

@Miciah: This pull request references Bugzilla bug 1880148, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1880148: Set DNS DaemonSet's maxUnavailable value to 10%

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Miciah]

/cherry-pick release-4.6

[openshift-cherrypick-robot]

@Miciah: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sgreene570]

Some quick comments.

[sgreene570]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, sgreene570

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Miciah,sgreene570]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@Miciah: All pull requests linked via external trackers have merged:

• openshift/cluster-dns-operator#217

Bugzilla bug 1880148 has been moved to the MODIFIED state.

In response to this:

Bug 1880148: Set DNS DaemonSet's maxUnavailable value to 10%

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@Miciah: #217 failed to apply on top of branch "release-4.6":

Applying: Set DNS DaemonSet's maxUnavailable value to 10%
Using index info to reconstruct a base tree...
M	assets/dns/daemonset.yaml
M	pkg/manifests/bindata.go
M	pkg/operator/controller/controller_dns_daemonset.go
M	pkg/operator/controller/controller_dns_daemonset_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/controller/controller_dns_daemonset_test.go
CONFLICT (content): Merge conflict in pkg/operator/controller/controller_dns_daemonset_test.go
Auto-merging pkg/operator/controller/controller_dns_daemonset.go
Auto-merging pkg/manifests/bindata.go
CONFLICT (content): Merge conflict in pkg/manifests/bindata.go
Auto-merging assets/dns/daemonset.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Set DNS DaemonSet's maxUnavailable value to 10%
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.