[release-4.6] Bug 1903887: Set DNS DaemonSet's maxUnavailable value to 10% #219
Conversation
openshift-ci-robot
added
the
bugzilla/severity-medium
|
@Miciah: This pull request references Bugzilla bug 1880148, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
openshift-ci-robot
added
the
approved
Miciah
changed the title
|
@Miciah: This pull request references Bugzilla bug 1903887, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -64,7 +65,14 @@ func computeDNSDegradedCondition(oldCondition *operatorv1.OperatorCondition, clu | |||
| Type: operatorv1.OperatorStatusTypeDegraded, | |||
| } | |||
| numberUnavailable := ds.Status.DesiredNumberScheduled - ds.Status.NumberAvailable | |||
| // TODO: Replace GetValueFromIntOrPercent with | |||
| // GetScaledValueFromIntOrPercent after rebasing on Kubernetes 1.20. | |||
There was a problem hiding this comment.
These TODO's won't apply to OCP 4.6. Should they be removed, or am I being too picky?
There was a problem hiding this comment.
Interesting question. ¯\_(ツ)_/¯
We wouldn't worry about that sort of thing in an automatic cherry-pick, but since this is a manual cherry-pick, we can tailor the change to the release branch. I'll keep the test as a comment but replace the to-do with an explanation of why it is not enabled on 4.6. Does that seem reasonable?
There was a problem hiding this comment.
Maybe I should just copy GetScaledValueFromIntOrPercent into dns_status.go for the backport. I'm wishing now I had done that in #217, and then to-do for 4.7 would be just to delete the copy and use the original after the rebase.
There was a problem hiding this comment.
No worries. Copying over the necessary functions into 4.6 sounds good to me. We can just worry about the rebase in 4.7 now. 😁
Miciah
force-pushed
the
BZ1903887-set-DNS-DaemonSet's-maxUnavailable-value-to-10-percent
branch
from
00e07d7
to
4189287
Compare
|
@Miciah: This pull request references Bugzilla bug 1903887, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@Miciah: This pull request references Bugzilla bug 1903887, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1903887, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1903887, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-bot: This pull request references Bugzilla bug 1903887, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
|
@openshift-bot: This pull request references Bugzilla bug 1903887, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@lihongan: This pull request references Bugzilla bug 1903887, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/bugzilla cc-qa |
|
@lihongan: This pull request references Bugzilla bug 1903887, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lihongan, Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Miciah: This pull request references Bugzilla bug 1903887, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci-robot
removed
the
bugzilla/severity-medium
|
@Miciah: This pull request references Bugzilla bug 1903887, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/severity-high
|
@lihongan: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
jwforres
added
the
cherry-pick-approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@Miciah: All pull requests linked via external trackers have merged: Bugzilla bug 1903887 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Enable rolling updates to scale linearly with the number of nodes by setting the maxUnavailable value to a percentage instead of the default value of 1.
assets/dns/daemonset.yaml: SetmaxUnavailableto 10%.pkg/manifests/bindata.go: Regenerate.pkg/operator/controller/controller_dns_daemonset.go(daemonsetConfigChanged): Check if the update strategy changed and update it if it did.pkg/operator/controller/controller_dns_daemonset_test.go(TestDaemonsetConfigChanged): Add test case to verify thatdaemonsetConfigChangeddetects updates tospec.updateStrategy.pkg/operator/controller/dns_status.go(getIntOrPercentValueSafely,getScaledValueFromIntOrPercent): New functions based on definitions in Kubernetes 1.20.(
computeDNSDegradedCondition): Handle percentages values formaxUnavailable.pkg/operator/controller/dns_status_test.go(TestComputeDNSDegradedCondition): New test.Manual cherry-pick of #217 and #221.