Bug 1880148: Fix DNS DaemonSet's updateStrategy stanza #221
Conversation
Fix the indentation of updateStrategy stanza in the DNS DaemonSet's yaml definition. Before this commit, the stanza was ignored because it was incorrectly indented. Follow-up to commit 3e54c3f. This commit fixes bug 1880148. https://bugzilla.redhat.com/show_bug.cgi?id=1880148 * assets/dns/daemonset.yaml: Fix indentation of updateStrategy stanza. * pkg/manifests/bindata.go: Regenerate.
openshift-ci-robot
added
bugzilla/severity-medium
|
@Miciah: This pull request references Bugzilla bug 1880148, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
daemonsets.json from the last e2e-aws-operator run shows the correct "updateStrategy": {
"rollingUpdate": {
"maxUnavailable": "10%"
},
"type": "RollingUpdate"
} |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah, sgreene570 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Miciah: All pull requests linked via external trackers have merged: Bugzilla bug 1880148 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix the indentation of
updateStrategystanza in the DNS DaemonSet's yaml definition. Before this PR, the stanza was ignored because it was incorrectly indented.Follow-up to #217.
assets/dns/daemonset.yaml: Fix indentation of updateStrategy stanza.pkg/manifests/bindata.go: Regenerate.