New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1829644: add relatedobjects for immediate creation by CVO #312

Merged

openshift-merge-robot merged 1 commit into openshift:master from deads2k:clusteroperator

Apr 18, 2020

Contributor

deads2k commented Apr 15, 2020

since openshift/cluster-version-operator#318 merged we can have our relatedObjects created immediately so must-gather always works.


          add relatedobjects for immediate creation by CVO

d94ae9f

Contributor Author

deads2k commented Apr 15, 2020

/cherrypick release-4.4

openshift-cherrypick-robot commented Apr 15, 2020

@deads2k: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from alaypatel07 and mfojtik

April 15, 2020 16:11

openshift-ci-robot added the approved label

Contributor

hexfusion commented Apr 16, 2020

/retest

Member

mfojtik commented Apr 16, 2020

/lgtm

openshift-ci-robot assigned mfojtik

openshift-ci-robot commented Apr 16, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [deads2k,mfojtik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the lgtm label

Member

mfojtik commented Apr 16, 2020

/retest

1 similar comment

Contributor

hexfusion commented Apr 16, 2020

/retest

Contributor

openshift-bot commented Apr 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments

Contributor

openshift-bot commented Apr 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 16, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

hexfusion commented Apr 17, 2020

/retest

Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments

Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

hexfusion commented Apr 17, 2020

/retest

Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment

Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

hexfusion commented Apr 17, 2020

/skip

Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments

Contributor

openshift-bot commented Apr 17, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 18, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot commented Apr 18, 2020 •

edited

@deads2k: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-azure	`d94ae9f`	link	`/test e2e-azure`
ci/prow/e2e-aws-disruptive	`d94ae9f`	link	`/test e2e-aws-disruptive`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot merged commit 96b3c64 into openshift:master

openshift-cherrypick-robot mentioned this pull request

Bug 1829645: add relatedobjects for immediate creation by CVO #315

Merged

openshift-cherrypick-robot commented Apr 18, 2020

@deads2k: new pull request created: #315

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

enxebre added a commit to enxebre/cluster-version-operator that referenced this pull request


          Update readme to include fast fill logic

a2ded12

This openshift#318 introduced a PrecreatingMode which actually let the CVO to push the clusterOperator in manifests.
This enables a new pattern for individual operators to set related objects into the clusterOperator defined in manifests/ openshift/cluster-kube-apiserver-operator#833
openshift/cluster-etcd-operator#312
openshift/cluster-kube-controller-manager-operator#398

enxebre mentioned this pull request

Update readme to include fast fill logic openshift/cluster-version-operator#363

Merged

hexfusion changed the title ~~add relatedobjects for immediate creation by CVO~~ Bug 1829644: add relatedobjects for immediate creation by CVO

openshift-ci-robot commented Apr 30, 2020

@deads2k: All pull requests linked via external trackers have merged: . Bugzilla bug 1829644 has been moved to the MODIFIED state.

In response to this:

Bug 1829644: add relatedobjects for immediate creation by CVO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment