-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1828830: add relatedobjects for immediate creation by CVO #398
Bug 1828830: add relatedobjects for immediate creation by CVO #398
Conversation
This openshift#318 introduced a PrecreatingMode which actually let the CVO to push the clusterOperator in manifests. This enables a new pattern for individual operators to set related objects into the clusterOperator defined in manifests/ openshift/cluster-kube-apiserver-operator#833 openshift/cluster-etcd-operator#312 openshift/cluster-kube-controller-manager-operator#398
/retest |
@deads2k: An error was encountered adding this pull request to the external tracker bugs for bug 1828830 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/bugzilla refresh
@soltysh: This pull request references Bugzilla bug 1828830, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@deads2k: All pull requests linked via external trackers have merged: openshift/cluster-kube-apiserver-operator#833, openshift/cluster-kube-controller-manager-operator#398. Bugzilla bug 1828830 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.4 |
@soltysh: new pull request created: #407 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
since openshift/cluster-version-operator#318 merged we can have our relatedObjects created immediately so must-gather always works.
/cherrypick release-4.4