Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump(*) update to kube 1.12 #177

Merged
merged 1 commit into from
Jan 31, 2019
Merged

bump(*) update to kube 1.12 #177

merged 1 commit into from
Jan 31, 2019

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Jan 29, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 29, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2019
@bparees
Copy link
Contributor Author

bparees commented Jan 29, 2019

/assign @coreydaley @legionus @dmage

@bparees bparees changed the title bump(*) update to kube 1.12 bump(*) update to kube 1.12 + various fixes Jan 29, 2019
@bparees
Copy link
Contributor Author

bparees commented Jan 29, 2019

@coreydaley the latest commit removes a couple places where we were setting modified=true that i don't think were correct.

As i understand it, we should only set modified=true if we modifed the CR itself (and thus need to call update). Generating/updating other resources (like routes, the deployment, etc) do not require updating the CR itself.

@coreydaley
Copy link
Member

@bparees That is also how i understand it, as a modification to the CR should trigger refreshing / rebuilding other resources that need that information

@coreydaley
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2019
@bparees bparees changed the title bump(*) update to kube 1.12 + various fixes bump(*) update to kube 1.12 Jan 30, 2019
@bparees
Copy link
Contributor Author

bparees commented Jan 30, 2019

/hold

@coreydaley i'm suspicious that the kube 1.12 update is causing some of the weird client behavior i'm seeing in these failures, so i've split the fixes out to a separate PR:
#179

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2019
@bparees bparees mentioned this pull request Jan 30, 2019
Merged
@bparees
Copy link
Contributor Author

bparees commented Jan 30, 2019

example of weird failure:

logs.go:77: E0130 01:21:26.807626       1 reflector.go:134] github.com/openshift/client-go/route/informers/externalversions/factory.go:101: Failed to list *v1.Route: the server could not find the requested resource (get routes.route.openshift.io)

in: https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_cluster-image-registry-operator/177/pull-ci-openshift-cluster-image-registry-operator-master-e2e-aws-operator/803/

@bparees bparees added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2019
@bparees
Copy link
Contributor Author

bparees commented Jan 30, 2019

these flakes are happening in 1.11 based operator PRs also, so
/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, coreydaley, dmage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees
Copy link
Contributor Author

bparees commented Jan 30, 2019

/retest

2 similar comments
@bparees
Copy link
Contributor Author

bparees commented Jan 30, 2019

/retest

@coreydaley
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 59eb6c3 into openshift:master Jan 31, 2019
@bparees bparees deleted the bump branch January 31, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmage dmage dmage approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@dmage dmage

@legionus legionus

@coreydaley coreydaley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bparees @coreydaley @openshift-bot @openshift-ci-robot @dmage @legionus @openshift-merge-robot