Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various fixes #179

Merged
merged 2 commits into from
Jan 30, 2019
Merged

various fixes #179

merged 2 commits into from
Jan 30, 2019

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Jan 30, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 30, 2019
@bparees bparees mentioned this pull request Jan 30, 2019
Merged
@bparees
Copy link
Contributor Author

bparees commented Jan 30, 2019

these were lgtm'd by @coreydaley in #177 but i've split them out to here. self-lgtm'ing.

@bparees bparees added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2019
@bparees
Copy link
Contributor Author

bparees commented Jan 30, 2019

@dmage @legionus please work with @openshift/sig-master to get to the bottom of these api flakes during your day today:

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_cluster-image-registry-operator/179/pull-ci-openshift-cluster-image-registry-operator-master-e2e-aws-operator/809/build-log.txt

logs.go:77: E0130 04:42:30.634114       1 controller.go:208] unable to sync: unable to apply objects: failed to create object *v1.Image, Name=cluster: the server could not find the requested resource (put images.config.openshift.io cluster), requeuing

"Unable to apply resources: unable to apply objects: failed to update object *v1.Image, Name=cluster: the server could not find the requested resource (put images.config.openshift.io cluster)"

logs.go:77: E0130 04:42:16.360590       1 reflector.go:136] github.com/openshift/client-go/route/informers/externalversions/factory.go:101: Failed to list *v1.Route: the server could not find the requested resource (get routes.route.openshift.io)

I can't think of any reason the images config CRD should not be defined by this point in the tests, and certainly there's no reason the routes api should be unavailable.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, dmage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit a897f83 into openshift:master Jan 30, 2019
@bparees bparees deleted the fixes branch January 31, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmage dmage dmage approved these changes

@legionus legionus Awaiting requested review from legionus

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bparees @openshift-bot @openshift-ci-robot @dmage @openshift-merge-robot