Bug 1833109: Refactoring for Azure Driver #588
Conversation
openshift-ci-robot
added
the
approved
ricardomaraschini
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
Yak shaving for future implementation of storage ManagementState.
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/test e2e-azure-operator These are passing on a development cluster, let's give it another try. |
|
/retest |
|
/retest we had some Azure throttling issues, restart. |
|
/retest |
ricardomaraschini
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @dmage |
ricardomaraschini
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@ricardomaraschini: This pull request references Bugzilla bug 1833109, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| return | ||
| } | ||
|
|
||
| cr.Status.StorageManaged = false |
There was a problem hiding this comment.
that's not verification, the function name is misleading
There was a problem hiding this comment.
Yes, makes sense. Updated.
| if storageAccountCreated && containerCreated { | ||
| cr.Status.StorageManaged = true | ||
| } else { | ||
| cr.Status.StorageManaged = false |
There was a problem hiding this comment.
afaik the previous version didn't do this, and this might be wrong
if someone decided to change the container name and keep autogenerated account, the storage should still be managed by the operator (because everything is created by the operator)
There was a problem hiding this comment.
That is true. The previous version was setting it to true if it created any of the resources (even though it was deleting both on Remove). I updated this to have the same behavior. PTAL.
pkg/storage/azure/azure.go
Outdated
|
|
||
| // processUPICconfig verifies if user provided configuration is complete and updates conditions | ||
| // and status appropriately. | ||
| func (d *driver) processUPICconfig(cr *imageregistryv1.Config) { |
There was a problem hiding this comment.
OH MY LORD!
Name was misguiding.
We should set storage managed to true in the following scenarios: - operator created StorageAccount - operator created Container - operator created StorageAccount and Container
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dmage, ricardomaraschini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
26 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@ricardomaraschini: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1833109 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Yak shaving for future implementation of storage ManagementState.