Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IR-181: Use only one replica on single node clusters #670

Merged
merged 1 commit into from
May 11, 2021
Merged

IR-181: Use only one replica on single node clusters #670

merged 1 commit into from
May 11, 2021

Conversation

dmage
Copy link
Contributor

@dmage dmage commented Mar 16, 2021

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2021
@dmage
Copy link
Contributor Author

dmage commented Apr 6, 2021

/hold
(until it gets all approvals)

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2021
@dmage
Copy link
Contributor Author

dmage commented Apr 6, 2021

/retest

@dmage
Copy link
Contributor Author

dmage commented Apr 6, 2021

/assign @ricardomaraschini

ricardomaraschini
ricardomaraschini approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2021
@dmage
Copy link
Contributor Author

dmage commented Apr 8, 2021

/assign @wzheng1 @bmcelvee @sferich888

Please review this PR and tag it with xxx-approved if everything is fine.

@dmage
Copy link
Contributor Author

dmage commented Apr 8, 2021

/retest

@wzheng1
Copy link

wzheng1 commented Apr 9, 2021

/assign @xiuwang Thanks!

@xiuwang
Copy link

xiuwang commented Apr 9, 2021

Test this pr with single node, the image-registry default replicas is 1.
$ oc get node
NAME STATUS ROLES AGE VERSION
ip-10-0-139-18.us-east-2.compute.internal Ready master 58m v1.20.0+5f82cdb
ip-10-0-148-187.us-east-2.compute.internal Ready worker 52m v1.20.0+5f82cdb
ip-10-0-189-41.us-east-2.compute.internal Ready master 57m v1.20.0+5f82cdb
ip-10-0-223-113.us-east-2.compute.internal Ready master 58m v1.20.0+5f82cdb
$ oc get pods -n openshift-image-registry
NAME READY STATUS RESTARTS AGE
cluster-image-registry-operator-688447bb48-lqbfp 1/1 Running 0 26m
image-registry-dc65bf8df-p8z2m 1/1 Running 0 33m
node-ca-24n85 1/1 Running 0 53m
node-ca-724qv 1/1 Running 0 53m
node-ca-p2cx7 1/1 Running 0 53m
node-ca-wgrdt 1/1 Running 0 53m

@xiuwang
Copy link

xiuwang commented Apr 9, 2021

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini, xiuwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dmage,ricardomaraschini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dmage
Copy link
Contributor Author

dmage commented Apr 9, 2021

@xiuwang for features we use xxx-labels, like this: #640 (comment)

@xiuwang
Copy link

xiuwang commented Apr 9, 2021

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Apr 9, 2021
@openshift-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2021
@dmage
Copy link
Contributor Author

dmage commented Apr 22, 2021

/retest

@bmcelvee
Copy link

/label docs-approved

@openshift-ci-robot openshift-ci-robot added the docs-approved Signifies that Docs has signed off on this PR label Apr 26, 2021
@dmage
Copy link
Contributor Author

dmage commented May 4, 2021

/retest

1 similar comment
@dmage
Copy link
Contributor Author

dmage commented May 6, 2021

/retest

@sferich888
Copy link
Contributor

/label px-approved
/unassign @sferich888

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label May 6, 2021
@dmage
Copy link
Contributor Author

dmage commented May 7, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2021
ricardomaraschini
ricardomaraschini approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini, xiuwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dmage,ricardomaraschini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees bparees added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 11, 2021 •
edited
Loading

@dmage: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-azure-operator 4fff856 link /test e2e-azure-operator
ci/prow/e2e-gcp 4fff856 link /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8ba84b7 into openshift:master May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardomaraschini ricardomaraschini ricardomaraschini approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@ricardomaraschini ricardomaraschini

@xiuwang xiuwang

@wzheng1 wzheng1

@bmcelvee bmcelvee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@dmage @wzheng1 @xiuwang @openshift-ci-robot @bmcelvee @sferich888 @openshift-bot @ricardomaraschini @bparees @openshift-merge-robot