Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #94 #105

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Revert #94 #105

merged 1 commit into from
Jan 17, 2019

Conversation

ironcladlou
Copy link
Contributor

Revert 8d6461c (#94) because it's the likely cause of hot loops and we need a solution immediately (because of the downstream effects on shared API limits).

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 16, 2019
@ironcladlou
Copy link
Contributor Author

/retest

@knobunc
Copy link

knobunc commented Jan 16, 2019

/lgtm
/approve

@Miciah
Copy link
Contributor

Miciah commented Jan 16, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. labels Jan 16, 2019
Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ironcladlou
Copy link
Contributor Author

/cc @smarterclayton

@ironcladlou
Copy link
Contributor Author

/retest

1 similar comment
@ironcladlou
Copy link
Contributor Author

/retest

Copy link
Contributor

@ramr ramr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, knobunc, Miciah, pravisankar, ramr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Miciah,ironcladlou,knobunc,pravisankar,ramr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ironcladlou
Copy link
Contributor Author

/retest

@ironcladlou
Copy link
Contributor Author

ironcladlou commented Jan 16, 2019

oops

@ironcladlou
Copy link
Contributor Author

/retest

@ironcladlou
Copy link
Contributor Author

/retest

@wking
Copy link
Member

wking commented Jan 16, 2019

Looks like that last e2e run hung, and that we have some work to do to clean up gracefully when we time out an e2e-aws pod:

2019/01/16 19:38:20 Running pod e2e-aws
2019/01/16 19:58:13 Container setup in pod e2e-aws completed successfully
2019/01/16 22:38:20 Copying artifacts from e2e-aws into /logs/artifacts/e2e-aws
2019/01/16 22:38:20 error: unable to signal to artifacts container to terminate in pod e2e-aws, triggering deletion: could not run remote command: unable to upgrade connection: container not found ("artifacts")
2019/01/16 22:38:20 error: unable to retrieve artifacts from pod e2e-aws: could not read gzipped artifacts: unable to upgrade connection: container not found ("artifacts")
E0116 22:38:25.093604      11 event.go:203] Server rejected event '&v1.Event{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:".157a7537f11b4ab0", GenerateName:"", Namespace:"ci-op-g0jfiqm7", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string(nil), Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, InvolvedObject:v1.ObjectReference{Kind:"", Namespace:"ci-op-g0jfiqm7", Name:"", UID:"", APIVersion:"", ResourceVersion:"", FieldPath:""}, Reason:"CiJobFailed", Message:"Running job pull-ci-openshift-cluster-ingress-operator-master-e2e-aws for PR https://github.com/openshift/cluster-ingress-operator/pull/105 in namespace ci-op-g0jfiqm7 from author ironcladlou", Source:v1.EventSource{Component:"ci-op-g0jfiqm7", Host:""}, FirstTimestamp:v1.Time{Time:time.Time{wall:0xbf080a784500c0b0, ext:11108907029836, loc:(*time.Location)(0x19ff4a0)}}, LastTimestamp:v1.Time{Time:time.Time{wall:0xbf080a784500c0b0, ext:11108907029836, loc:(*time.Location)(0x19ff4a0)}}, Count:1, Type:"Warning", EventTime:v1.MicroTime{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, Series:(*v1.EventSeries)(nil), Action:"", Related:(*v1.ObjectReference)(nil), ReportingController:"", ReportingInstance:""}': 'events ".157a7537f11b4ab0" is forbidden: unable to create new content in namespace ci-op-g0jfiqm7 because it is being terminated' (will not retry!)
2019/01/16 22:38:26 Ran for 3h5m9s
error: could not run steps: template pod "e2e-aws" failed: pod e2e-aws was already deleted

@ironcladlou
Copy link
Contributor Author

/retest

@wking
Copy link
Member

wking commented Jan 17, 2019

e2e-aws had:

fail [k8s.io/kubernetes/test/e2e/scheduling/resource_quota.go:129]: Expected error:
    <*errors.errorString | 0xc4200d1560>: {
        s: "timed out waiting for the condition",
    }
    timed out waiting for the condition
not to have occurred

failed: (1m25s) 2019-01-17T00:10:24 "[sig-scheduling] ResourceQuota should create a ResourceQuota and capture the life of a secret. [Suite:openshift/conformance/parallel] [Suite:k8s]"

and a few more.

/retest

@wking
Copy link
Member

wking commented Jan 17, 2019

e2e-aws:

Jan 17 01:41:56.619 - 629s E openshift-apiserver OpenShift API is not responding to GET requests

and more.

/retest

@openshift-merge-robot openshift-merge-robot merged commit 2fffb5f into openshift:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants