Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.9] Bug 2014938: Use fake dns provider with external cp topology only in IBM Cloud case #666

Merged
merged 1 commit into from Nov 15, 2021
Merged

[release-4.9] Bug 2014938: Use fake dns provider with external cp topology only in IBM Cloud case #666

merged 1 commit into from Nov 15, 2021

Conversation

openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 18, 2021 •
edited by Miciah

This is an automated cherry-pick of #659

/assign Miciah

When support for IBM Cloud was added in #630, a check was added to prevent the operator from managing DNS on clusters with the "External" control-plane topology. This is because when the platform is "IBMCloud" and the control-plane topology is "External", that means the platform is ROKS, and on ROKS, DNS is managed outside the cluster. However, for other platforms (AWS, Azure, and GCP), "External" control-plane topology is used for Hypershift, and in this case, the operator should still manage DNS for ingresscontrollers. This PR changes the aforementioned check so that the operator still manages DNS in the Hypershift case.

@csrwng
Use fake dns provider with external cp topology only in IBM Cloud case
ec0217a 
With other platforms such as AWS, Azure, etc. and an external control
plane (ie. Hypershift), we still want to create real DNS records for the
wildcard route.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 18, 2021
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

@openshift-cherrypick-robot: Bugzilla bug 2011972 has been cloned as Bugzilla bug 2014938. Retitling PR to link against new bug.
/retitle [release-4.9] Bug 2014938: Use fake dns provider with external cp topology only in IBM Cloud case

In response to this:

[release-4.9] Bug 2011972: Use fake dns provider with external cp topology only in IBM Cloud case

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.9] Bug 2011972: Use fake dns provider with external cp topology only in IBM Cloud case [release-4.9] Bug 2014938: Use fake dns provider with external cp topology only in IBM Cloud case Oct 18, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 18, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2014938, which is invalid:

  • expected dependent Bugzilla bug 2011972 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2014938: Use fake dns provider with external cp topology only in IBM Cloud case

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2014938, which is invalid:

  • expected dependent Bugzilla bug 2011972 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.9] Bug 2014938: Use fake dns provider with external cp topology only in IBM Cloud case

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah Miciah added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 18, 2021
@candita
Copy link
Contributor

candita commented Oct 26, 2021 •
edited by openshift-ci bot

error running backup collection: errors ocurred while gathering data:
[skipping gathering secrets/support due to error: secrets "support" not found, skipping gathering EgressFirewall.k8s.ovn.org due to error: the server doesn't have a resource type "EgressFirewall", skipping gathering EgressIP.k8s.ovn.org due to error: the server doesn't have a resource type "EgressIP", skipping gathering endpoints/host-etcd-2 due to error: endpoints "host-etcd-2" not found]error: gather never finished for pod must-gather-wjk8m: timed out waiting for the condition

/test e2e-aws-operator

@sjenning sjenning mentioned this pull request Oct 27, 2021
Merged
@csrwng
Copy link
Contributor

csrwng commented Oct 27, 2021

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2021

@csrwng: This pull request references Bugzilla bug 2014938, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2011972 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2011972 targets the "4.10.0" release, which is one of the valid target releases: 4.10.0
  • bug has dependents

Requesting review from QA contact:
/cc @lihongan

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 27, 2021
@openshift-ci openshift-ci bot requested a review from lihongan October 27, 2021 10:26
@csrwng
Copy link
Contributor

csrwng commented Oct 27, 2021

/retest-required

1 similar comment
@csrwng
Copy link
Contributor

csrwng commented Oct 27, 2021

/retest-required

@csrwng csrwng mentioned this pull request Oct 27, 2021
Closed
@alvaroaleman
Copy link

/retest-required

1 similar comment
@alvaroaleman
Copy link

/retest-required

@Miciah
Copy link
Contributor

Miciah commented Oct 28, 2021

/lgtm

@Miciah
Copy link
Contributor

Miciah commented Oct 28, 2021

/test e2e-azure-operator

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2021
@Miciah
Copy link
Contributor

Miciah commented Oct 28, 2021 •
edited

/hold
We need #664 #673 to merge so we can test #666 on Azure.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2021
@Miciah
Copy link
Contributor

Miciah commented Nov 4, 2021

#673 has merged.
/test e2e-azure-operator
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2021
@hardys
Copy link

hardys commented Nov 9, 2021

[patch-manager] Skipping as per the prow config for this repo, the cherry-pick-approved label should be applied by one of @lihongan @quarterpin @melvinjoseph86 @ShudiLi

@alvaroaleman
Copy link

@lihongan @quarterpin @melvinjoseph86 @ShudiLi anything we can do to help getting this cherry-pick approved?

@lihongan
Copy link
Contributor

lihongan commented Nov 15, 2021 •
edited

/cherry-pick-approve

@lihongan
Copy link
Contributor

/cherry-pick-approved

@lihongan
Copy link
Contributor

/cherry-pick-approve

@lihongan
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 15, 2021
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 07c25a6 into openshift:release-4.9 Nov 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2014938 has been moved to the MODIFIED state.

In response to this:

[release-4.9] Bug 2014938: Use fake dns provider with external cp topology only in IBM Cloud case

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candita candita Awaiting requested review from candita

@frobware frobware Awaiting requested review from frobware

@lihongan lihongan Awaiting requested review from lihongan

Assignees

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@openshift-cherrypick-robot @candita @csrwng @alvaroaleman @Miciah @hardys @lihongan @openshift-bot @openshift-merge-robot