-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.9] Bug 2014711: Fix for Azure dns privateZone degrade e2e test #673
[release-4.9] Bug 2014711: Fix for Azure dns privateZone degrade e2e test #673
Conversation
Follow-up to commit fe8c1ee. * test/e2e/dns_ingressdegrade_test.go (updateDNSConfig): Replace integer literals with len(injectError). Change injectError to a const.
@Miciah: This pull request references Bugzilla bug 2014711, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Miciah: This pull request references Bugzilla bug 2014711, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Miciah: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/skip |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-azure-operator |
/bugzilla refresh Recalculating validity in case the underlying Bugzilla bug has changed. |
@openshift-bot: This pull request references Bugzilla bug 2014711, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Change looks good but need bugzilla/valid-bug label first before this can be merged in. |
/bugzilla refresh |
@Miciah: This pull request references Bugzilla bug 2014711, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Miciah: All pull requests linked via external trackers have merged: Bugzilla bug 2014711 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a manual cherry-pick of #662 and #672.
The recently added
TestIngressStatus
test fails on Azure, causing the e2e-azure-operator CI jobs in the cluster-ingress-operator repository to fail consistently. This backport fixes the test so that it passes on Azure. This is needed so that we can verify cluster-ingress-operator PRs to the release-4.9 branch on Azure. This change has no direct impact on users.