OCPBUGS-2334: Added nil check for service object on load balancer scope change #839
Conversation
|
/retest |
|
/retest Unrelated failure |
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
/retest Pod pending timeout again.. |
|
/retest Pod pending timeout again.. |
|
/retest Pod pending timeout again.. |
|
/retest |
gcs278
force-pushed
the
scope-change-panic
branch
from
cbad89c
to
d8e106c
Compare
|
/lgtm |
|
No |
|
Could you add a reference/link to the bug in the commit message and put reference to the bug in the PR title? |
|
/retitle OCPBUGS-2334: Added nil check for service object on load balancer scope change |
openshift-ci
bot
changed the title
|
@gcs278: An error was encountered querying GitHub for users with public email (mjoseph@redhat.com) for bug OCPBUGS-2334 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout
Please contact an administrator to resolve this issue, then request a bug refresh with In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
No TestScopeChange issues on round # 2! |
…hen using ingress.operator.openshift.io/auto-delete-load-balancer annotation and changing scope of loadbalancer from external to internal. Add unit tests for computeAllowedSourceRanges.
gcs278
force-pushed
the
scope-change-panic
branch
from
d8e106c
to
56b9873
Compare
@Miciah done. I'm using OCPBUGS-2334, let me know if that isn't the bug you want, but I think it fixes it based on testing and the runs we've had so far. |
|
/jira refresh |
openshift-ci-robot
added
the
jira/severity-critical
openshift-ci-robot
added
jira/valid-bug
|
@gcs278: This pull request references Jira Issue OCPBUGS-2334, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks! |
|
/jira refresh |
|
@Miciah: This pull request references Jira Issue OCPBUGS-2334, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
https://issues.redhat.com/browse/OCPBUGS-2334 still points to #840. I'll update it manually. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Hm, I'll have to ask someone to help me update Jira. |
|
/retest |
|
e2e-aws-operator failed because one of the control-plane nodes was unschedulable, causing numerous components to fail to roll out (dns, image-registry, kube-apiserver, kube-controller-manager, kube-scheduler, network, storage). /test e2e-aws-operator |
|
Most of the failures of the e2e-aws-operator job on this PR have been related to build failures, install failures, or failures in unrelated components. In the cases of two failures (1581056173417697280, 1580986810715082752), the e2e-aws-operator job ran through the operator test suite and failed on tests that are known to be flaky: |
|
@Miciah: Overrode contexts on behalf of Miciah: ci/prow/e2e-aws-operator In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-gcp-ovn-serial |
|
/refresh |
|
@gcs278: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-2334 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Added nil check for service object which without causes the ingress operator to panic when using ingress.operator.openshift.io/auto-delete-load-balancer annotation and changing scope of loadbalancer from external to internal.
pkg/operator/controller/ingress/status.go: Add nil check forcomputeAllowedSourceRangespkg/operator/controller/ingress/status_test.go: Add unit test forcomputeAllowedSourceRanges