Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-2429: Fix TestReloadInterval min value test cases and race conditions #842

Merged
merged 1 commit into from
Oct 15, 2022
Merged

OCPBUGS-2429: Fix TestReloadInterval min value test cases and race conditions #842

merged 1 commit into from
Oct 15, 2022

Conversation

gcs278
Copy link
Contributor

@gcs278 gcs278 commented Oct 14, 2022

OCPBUGS-2429: Fix TestReloadInterval min value test cases to 1s and fix race condition in which it passes as a false positive by forcing the ingress operator to recreated the router deployment instead of waiting on the ingress operator to report Available.

  • test/e2e/reloadinterval_test.go: Add deletion of router deployment to trigger reconcile and fix min value test cases

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 14, 2022
@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-2429, which is invalid:

  • expected the bug to target the "4.12.0" version, but it targets "4.12.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

OCPBUGS-2429: Fix TestReloadInterval min value test cases to 1s and fix race condition in which it passes as a false positive by forcing the ingress operator to recreated the router deployment instead of waiting on the ingress operator to report Available.

  • test/e2e/reloadinterval_test.go: Add deletion of router deployment to trigger reconcile and fix min value test cases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gcs278
Copy link
Contributor Author

gcs278 commented Oct 14, 2022

/refresh jira

@gcs278 gcs278 force-pushed the reloadinternval-e2e-fix branch 3 times, most recently from 645b694 to b983acc Compare October 14, 2022 20:36
@gcs278
Copy link
Contributor Author

gcs278 commented Oct 14, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 14, 2022
@openshift-ci-robot
Copy link
Contributor

@gcs278: This pull request references Jira Issue OCPBUGS-2429, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from lihongan October 14, 2022 20:37
@gcs278
OCPBUGS-2429: Fix TestReloadInterval min value test cases to 1s and
08803d1 
fix race condition in which it passes as a false positive by forcing
the ingress operator to recreated the router deployment instead of
waiting on the ingress operator to report Available.

- test/e2e/reloadinterval_test.go: Add deletion of router deployment
  to trigger reconcile and fix min value test cases
@Miciah
Copy link
Contributor

Miciah commented Oct 14, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@gcs278 gcs278 mentioned this pull request Oct 14, 2022
Closed
@Miciah Miciah mentioned this pull request Oct 15, 2022
Merged
@Miciah
Copy link
Contributor

Miciah commented Oct 15, 2022

/retest-required
now that #839 has merged.

miheer
miheer reviewed Oct 15, 2022
View reviewed changes
test/e2e/reloadinterval_test.go
{"set reloadInterval 5us", metav1.Duration{Duration: 5 * time.Microsecond}, "5s", true},
{"set reloadInterval 500ms", metav1.Duration{Duration: 500 * time.Millisecond}, "5s", true},
{"set reloadInterval 200ns", metav1.Duration{Duration: 200 * time.Nanosecond}, "1s", true},
{"set reloadInterval 5us", metav1.Duration{Duration: 5 * time.Microsecond}, "1s", true},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does setting to 1s really help ? Won't it cause load on the router ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly - it's the value the test is looking for in the router deployment ENV variable. So no load affects, just a comparison value that was wrong.

@miheer
Copy link
Contributor

miheer commented Oct 15, 2022 •
edited
Loading

The PR looks lgtm so /lgtm

@miheer
Copy link
Contributor

miheer commented Oct 15, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 15, 2022

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 68121ce into openshift:master Oct 15, 2022
@openshift-ci-robot
Copy link
Contributor

@gcs278: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-2429 has been moved to the MODIFIED state.

In response to this:

OCPBUGS-2429: Fix TestReloadInterval min value test cases to 1s and fix race condition in which it passes as a false positive by forcing the ingress operator to recreated the router deployment instead of waiting on the ingress operator to report Available.

  • test/e2e/reloadinterval_test.go: Add deletion of router deployment to trigger reconcile and fix min value test cases

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Oct 15, 2022
Merged
Merged
@ShudiLi
Copy link
Member

ShudiLi commented Oct 26, 2022

/label qe-approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2022

@ShudiLi: The label(s) /label qe-approve cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label qe-approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ShudiLi
Copy link
Member

ShudiLi commented Oct 26, 2022

cancel /label qe-approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miheer miheer miheer left review comments

@frobware frobware Awaiting requested review from frobware

@Miciah Miciah Awaiting requested review from Miciah

@lihongan lihongan Awaiting requested review from lihongan

Assignees

@miheer miheer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gcs278 @openshift-ci-robot @Miciah @miheer @ShudiLi @openshift-merge-robot