Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include operator resource deletion recovery for revision controller #438

Closed
wants to merge 0 commits into from

Conversation

damemi
Copy link

@damemi damemi commented Apr 25, 2019

Bumps to include changes from openshift/library-go#368

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 25, 2019
@damemi
Copy link
Author

damemi commented Apr 25, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2019
@damemi
Copy link
Author

damemi commented Apr 25, 2019

/retest

2 similar comments
@damemi
Copy link
Author

damemi commented Apr 25, 2019

/retest

@mfojtik
Copy link
Contributor

mfojtik commented Apr 26, 2019

/retest

@damemi damemi force-pushed the bump-libgo-deletion-recovery branch from ac50e1c to 13b9f57 Compare April 26, 2019 15:21
@damemi
Copy link
Author

damemi commented Apr 26, 2019

/hold cancel

this is merged in library-go now

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2019
@openshift-ci-robot
Copy link

The following users are mentioned in OWNERS file(s) but are not members of the openshift org.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 26, 2019
@stevekuznetsov stevekuznetsov removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Apr 26, 2019
@damemi
Copy link
Author

damemi commented Apr 29, 2019

/retest

2 similar comments
@damemi
Copy link
Author

damemi commented Apr 29, 2019

/retest

@damemi
Copy link
Author

damemi commented Apr 29, 2019

/retest

@damemi damemi closed this Apr 29, 2019
@damemi damemi force-pushed the bump-libgo-deletion-recovery branch from 13b9f57 to 7865094 Compare April 29, 2019 20:23
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 29, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damemi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2019
@damemi damemi deleted the bump-libgo-deletion-recovery branch April 29, 2019 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants