New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1732945: Report infra provider and feature set metrics #531
Bug 1732945: Report infra provider and feature set metrics #531
Conversation
The infrastructure provider metric summarizes the desired type and region (if any) to prometheus, based on the desired config. If type is not recognized it is passed along, if it is empty it is set as empty. The featureset metric reports what featureset is in use and 1 if it is "supported" and 0 if it is "not supported" (in the tech preview sense).
@smarterclayton: This pull request references an invalid Bugzilla bug:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#535 is open to fix the verify-deps issue you are seeing That aside, I see two different PRs both attempting to backport this fix. This one, and #537 cc @p0lyn0mial I can't approve both of them. Let me know which one of these you actually want approved. |
/bugzilla refresh |
@p0lyn0mial: This pull request references an invalid Bugzilla bug:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@p0lyn0mial: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
let's take this one. |
/retest |
@smarterclayton: This pull request references a valid Bugzilla bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Picked #535 into this PR |
Can I get approval and lgtm on this now that we're back to green? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: derekwaynecarr, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@smarterclayton: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The infrastructure provider metric summarizes the desired type and
region (if any) to prometheus, based on the desired config. If type
is not recognized it is passed along, if it is empty it is set as
empty.
The featureset metric reports what featureset is in use and 1 if it
is "supported" and 0 if it is "not supported" (in the tech preview
sense).