Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move rbac for cluster-policy-controller leader lock to kcm-o #299

Merged
merged 1 commit into from
Oct 22, 2019
Merged

move rbac for cluster-policy-controller leader lock to kcm-o #299

merged 1 commit into from
Oct 22, 2019

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Oct 22, 2019 •
edited
Loading

This PR adds role and rolebinding necessary for creating lease leader lock during upgrades from 4.2 -> 4.3, with split of quota and security controllers from openshift-controller-manager to cluster-policy-controller.

@deads2k

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 22, 2019
This was referenced Oct 22, 2019
Merged
Merged
@sallyom
Copy link
Contributor Author

sallyom commented Oct 22, 2019

the role/rolebinding is not created. 🤷‍♀️ I have to create it elsewhere? hm..

@deads2k
Copy link
Contributor

deads2k commented Oct 22, 2019

you forgot to add these to the targetcontroller resources list, right?

@sallyom
Copy link
Contributor Author

sallyom commented Oct 22, 2019

you forgot to add these to the targetcontroller resources list, right?

yes, and I've added them now, thanks : )

@sallyom
Copy link
Contributor Author

sallyom commented Oct 22, 2019

I've confirmed the role, rolebinding are created

deads2k
deads2k reviewed Oct 22, 2019
View reviewed changes
...ta/v4.1.0/kube-controller-manager/leader-election-cluster-policy-controller-rolebinding.yaml
subjects:
- kind: User
name: system:kube-controller-manager
- kind: ServiceAccount
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugly, but I'll let you have it to get this thing crash landed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, fix w/ a follow-up

@deads2k
Copy link
Contributor

deads2k commented Oct 22, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sallyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2019
@openshift-merge-robot openshift-merge-robot merged commit 5c3fc2f into openshift:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sallyom @deads2k @openshift-ci-robot @openshift-merge-robot