Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm role/binding for cluster-policy-controller leader lock, goes in kcm-o #125

Merged

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Oct 22, 2019

role & rolebinding for cluster-policy-controller lease leader lock move to openshift/cluster-kube-controller-manager-operator.
PR to add to kcm-o: openshift/cluster-kube-controller-manager-operator#299

@sallyom
Copy link
Contributor Author

sallyom commented Oct 22, 2019

/hold

until this merges: openshift/cluster-kube-controller-manager-operator#299

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2019
@sallyom
Copy link
Contributor Author

sallyom commented Oct 24, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2019
@sallyom
Copy link
Contributor Author

sallyom commented Oct 24, 2019

/retest

Copy link

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2019
@deads2k
Copy link
Contributor

deads2k commented Oct 24, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sallyom, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2019
@openshift-merge-robot openshift-merge-robot merged commit fa40953 into openshift:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants