Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more checks for kube-scheduler #3242

Conversation

ravisantoshgudimetla
Copy link
Contributor

As of now, we are not checking bindata, deps etc. Adding those checks

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 26, 2019
@openshift-ci-robot
Copy link
Contributor

@ravisantoshgudimetla: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-kube-scheduler-operator/master/verify 2a88405 link /test pj-rehearse
ci/prow/pj-rehearse 2a88405 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Mar 26, 2019

The rehearse is expected to fail because of the bin data mismatch in current HEAD. openshift/cluster-kube-scheduler-operator#79 should address the mismatch.

@sjenning
Copy link
Contributor

/lgtm
@smarterclayton @stevekuznetsov could one of you force merge this (see #3242 (comment))

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravisantoshgudimetla, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8ea316e into openshift:master Mar 26, 2019
@openshift-ci-robot
Copy link
Contributor

@ravisantoshgudimetla: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-cluster-kube-scheduler-operator-master.yaml using file ci-operator/config/openshift/cluster-kube-scheduler-operator/openshift-cluster-kube-scheduler-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-cluster-kube-scheduler-operator-master.yaml using file ci-operator/config/openshift/cluster-kube-scheduler-operator/openshift-cluster-kube-scheduler-operator-master.yaml

In response to this:

As of now, we are not checking bindata, deps etc. Adding those checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ravisantoshgudimetla
Copy link
Contributor Author

ravisantoshgudimetla commented Mar 26, 2019

@sjenning - These are not required jobs, so merge would continue.

EDIT: Just as I said, merge-bot merged it :).

@sjenning
Copy link
Contributor

so they aren't. nevermind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
4 participants