Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1915473: Annotate manifests for single-node-developer cluster profile #1003

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Bug 1915473: Annotate manifests for single-node-developer cluster profile #1003

merged 1 commit into from
Jan 13, 2021

Conversation

cfergeau
Copy link
Contributor

@cfergeau cfergeau commented Dec 3, 2020

This partially implements phase 1 of
https://github.com/openshift/enhancements#482 and does not change behavior.
Initially, all cluster-monitoring-operator manifests are included in the
single-node-developer cluster profile. Follow-on PRs may exclude any of
these that are not needed in the profile.

  • I added CHANGELOG entry for this change.
  • No user facing changes, so no entry in CHANGELOG was needed.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2020
@lilic
Copy link
Contributor

lilic commented Dec 3, 2020

@cfergeau hey, can you link to the enhancement? https://github.com/openshift/enhancements#482 as this link is a dead end. Thanks!

@cfergeau
Copy link
Contributor Author

cfergeau commented Dec 3, 2020

@cfergeau hey, can you link to the enhancement? https://github.com/openshift/enhancements#482 as this link is a dead end. Thanks!

Oh sorry for that, fixed now! It was referring to ttps://github.com/openshift/enhancements/pull/482 which has now been pushed https://github.com/openshift/enhancements/blob/master/enhancements/single-node-developer-cluster-profile.md

@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2020
@simonpasquier
Copy link
Contributor

👋 @cfergeau you'd need to rebase on top of master because #998 has landed and I guess we want the single-node-developer annotation here too.

@cfergeau
Copy link
Contributor Author

cfergeau commented Dec 9, 2020

/retest

1 similar comment
@cfergeau
Copy link
Contributor Author

/retest

simonpasquier
simonpasquier reviewed Dec 16, 2020
View reviewed changes
.../0000_50_cluster-monitoring-operator_00_0alertmanager-config-custom-resource-definition.yaml
@@ -5,6 +5,7 @@ metadata:
controller-gen.kubebuilder.io/version: v0.2.4
include.release.openshift.io/ibm-cloud-managed: "true"
include.release.openshift.io/self-managed-high-availability: "true"
include.release.openshift.io/single-node-developer: "true"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's something not right in our tooling because this file (and the other CRDs) are generated from Jsonnet. The new annotation should be added to jsonnet/add-release-annotation.libsonnet. I'm investigating why the CI didn't fail.

@simonpasquier
Copy link
Contributor

/hold

@cfergeau this PR needs a rebase on the latest master to include d1476bb. Then you'll see that manual modifications to manifests/*custom-resource-definition.yaml will be overriden by make clean generate.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2020
@cfergeau
Copy link
Contributor Author

/retest

@cfergeau
Annotate manifests for single-node-developer cluster profile
a036fbe 
This partially implements phase 1 of https://github.com/openshift/enhancements#482
and does not change behavior. Initially, all cluster-monitoring-operator
manifests are included in the single-node-developer cluster profile.
Follow-on PRs may exclude any of these that are not needed in the
profile.
@simonpasquier
Copy link
Contributor

/unhold
/lgtm

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 22, 2020
@cfergeau cfergeau changed the title Annotate manifests for single-node-developer cluster profile Bug 1915473: Annotate manifests for single-node-developer cluster profile Jan 12, 2021
@openshift-ci-robot
Copy link
Contributor

@cfergeau: This pull request references Bugzilla bug 1915473, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1915473: Annotate manifests for single-node-developer cluster profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jan 12, 2021
@cfergeau
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 12, 2021
@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 12, 2021
@openshift-ci-robot
Copy link
Contributor

@cfergeau: This pull request references Bugzilla bug 1915473, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6ba1db4 into openshift:master Jan 13, 2021
@openshift-ci-robot
Copy link
Contributor

@cfergeau: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with /bugzilla refresh.

Bugzilla bug 1915473 has not been moved to the MODIFIED state.

In response to this:

Bug 1915473: Annotate manifests for single-node-developer cluster profile

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Mar 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

@lilic lilic Awaiting requested review from lilic

Assignees

@simonpasquier simonpasquier

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cfergeau @lilic @simonpasquier @openshift-ci-robot @openshift-bot @openshift-merge-robot