-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack: scripts: lint shellscripts and remove unused jenkins scripts #407
Conversation
I am wondering, why wasn't this catched in CI runs? Also, can we add shellheck on all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom, s-urbaniak, squat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Actually, if we want to ensure this doesn’t break again, we need to make shellcheck part of the ci test stage |
Shellcheck as part of CI: openshift/release#4437 |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
Without it
make
is broken as shell scripts don't pass shellcheck.Additionally I moved
deploy-on-openshift.sh
script tohack/
directory to remove confusion betweenscripts/
andhack/
. It was easier to move this one remaining script tohack/
than to move everything toscripts/
/cc @s-urbaniak @smarterclayton