Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1741055: pkg/client: Set Reason in ClusterOperatorStatusCondition #440

Merged
merged 4 commits into from
Sep 9, 2019
Merged

Bug 1741055: pkg/client: Set Reason in ClusterOperatorStatusCondition #440

merged 4 commits into from
Sep 9, 2019

Conversation

lilic
Copy link
Contributor

@lilic lilic commented Aug 14, 2019

This backports the setting of the Reason field to release-4.1 branch. See PR #431 for the background.

cc @s-urbaniak @paulfantom

@lilic
pkg/*: Set Reason field in ClusterOperatorStatus
333ebd5 
Reason field is used to create the metrics in ClusterVersionOperator.
@lilic
pkg/strings: Add ToPascalCase func
2ac245c 
This function converts a string to PascalCase which is upper case
camelCase.
@lilic
pkg/client/status_reporter.go: Add license header
c017334
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 14, 2019
@openshift-ci-robot
Copy link
Contributor

@lilic: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1741055: pkg/client: Set Reason in ClusterOperatorStatusCondition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 14, 2019
@s-urbaniak
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 14, 2019
@lilic
Copy link
Contributor Author

lilic commented Aug 15, 2019

This is missing the cherry-pick-approved label. :)

@s-urbaniak
Copy link
Contributor

ping @derekwaynecarr ?

@eparis
Copy link
Member

eparis commented Aug 20, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@eparis: This pull request references Bugzilla bug 1741055, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eparis
Copy link
Member

eparis commented Aug 20, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 20, 2019
@openshift-ci-robot
Copy link
Contributor

@eparis: This pull request references Bugzilla bug 1741055, which is invalid:

  • expected dependent Bugzilla bug 1743725 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 20, 2019
@eparis
Copy link
Member

eparis commented Aug 24, 2019

/bugzilla refresh
I believe we are still awaiting QE review on the 4.2/master issue.

@openshift-ci-robot
Copy link
Contributor

@eparis: This pull request references Bugzilla bug 1741055, which is invalid:

  • expected dependent Bugzilla bug 1743725 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh
I believe we are still awaiting QE review on the 4.2/master issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lilic
Copy link
Contributor Author

lilic commented Aug 26, 2019 •
edited
Loading

I believe we are still awaiting QE review on the 4.2/master issue.

@eparis Yes, we are still waiting with QE, will do a bugzilla refresh when it's verified in 4.2 Thanks for staying on top of this!

@lilic lilic mentioned this pull request Sep 3, 2019
Merged
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2019
@s-urbaniak
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LiliC, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lilic
Copy link
Contributor Author

lilic commented Sep 9, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@lilic: This pull request references Bugzilla bug 1741055, which is valid.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 9, 2019
@lilic
Copy link
Contributor Author

lilic commented Sep 9, 2019

@eparis this is now ready to be merged, as the 4.2 bugzilla was verified, thanks!

@mfojtik mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 9, 2019
@openshift-merge-robot openshift-merge-robot merged commit 3d38297 into openshift:release-4.1 Sep 9, 2019
@openshift-ci-robot
Copy link
Contributor

@lilic: All pull requests linked via external trackers have merged. Bugzilla bug 1741055 has been moved to the MODIFIED state.

In response to this:

Bug 1741055: pkg/client: Set Reason in ClusterOperatorStatusCondition

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lilic lilic deleted the backport-reason branch September 9, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz Awaiting requested review from brancz

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

Assignees

@s-urbaniak s-urbaniak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lilic @openshift-ci-robot @s-urbaniak @eparis @mfojtik @openshift-merge-robot