Bug 1846805: Remove kube-mixin direct dependancy #898
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
|
/lgtm |
lilic
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
lilic
changed the title
openshift-ci-robot
added
bugzilla/severity-low
|
@lilic: This pull request references Bugzilla bug 1846805, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, paulfantom, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@lilic: Some pull requests linked via external trackers have merged: openshift/cluster-monitoring-operator#898, kubernetes-monitoring/kubernetes-mixin#443. The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Doesn't this make it significantly harder to get changes from kubernetes-mixin into this project as one would have to make an extra adjustment in kube-prometheus instead of bumping the version here and regenerating? |
|
@RiRa12621 if kubernetes-mixin has to be bumped, it should be bumped in kube-prometheus in the first place. That was actually the motivation for this PR in the first place. kubernetes-mixin was bumped in kube-prometheus, but when vendoring kube-prometheus changes we overlooked the bump and things started breaking. |
We don't want any critical alerts firing. Watchdog is severity=none [1]. AlertmanagerReceiversNotConfigured is severity=warning [2]. KubeAPILatencyHigh was dropped in openshift/cluster-monitoring-operator#898, 2020-08-03, and was severity=warning anyway. [1]: https://github.com/openshift/cluster-monitoring-operator/blob/776379a9616be1cbea49dd86086d8be8230370ce/assets/prometheus-k8s/rules.yaml#L2326-L2336 [2]: https://github.com/openshift/cluster-monitoring-operator/blob/776379a9616be1cbea49dd86086d8be8230370ce/assets/prometheus-k8s/rules.yaml#L924-L933
KubeAPILatencyHigh was dropped in openshift/cluster-monitoring-operator#898, 2020-08-03, 4.6 [1]. [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1846805#c13
https://github.com/kubernetes-monitoring/kubernetes-mixin should be pinned via kube-promethus https://github.com/coreos/kube-prometheus/blob/release-0.6/jsonnet/kube-prometheus/jsonnetfile.json#L48