Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1858198: Fix TLS cipher suites #54

Merged
merged 2 commits into from Aug 4, 2020

Conversation

paulfantom
Copy link
Contributor

@paulfantom paulfantom commented Aug 3, 2020

Use the same settings as in prometheus-operator/kube-prometheus#616

change global variable name to prevent overriding it in CMO.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2020
@paulfantom paulfantom changed the title Fix TLS cipher suites Bug 1858198: Fix TLS cipher suites Aug 3, 2020
@lilic
Copy link

lilic commented Aug 3, 2020

/lgtm

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilic, paulfantom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@paulfantom
Copy link
Contributor Author

Waiting for openshift/cluster-monitoring-operator#898

@paulfantom
Copy link
Contributor Author

/unhold

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6544e85 into openshift:master Aug 4, 2020
@paulfantom paulfantom deleted the tls branch August 4, 2020 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants