Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2095772: bindata: managed: reduce memory requests to align with observed usage #1479

Merged
merged 1 commit into from Jun 15, 2022
Merged

Bug 2095772: bindata: managed: reduce memory requests to align with observed usage #1479

merged 1 commit into from Jun 15, 2022

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Jun 9, 2022 •
edited

Working with PerfScale on Hypershift, we observed a roughly 3x overprovision on memory requests for the containers within ovnkube-master pods. This equates to a memory request ~3Gi (1Gi per pod) over what is required for an HA control plane.

This PR brings memory requests in line with observe P90 usage as determined by PerfScale.

Big thanks to @mukrishn for getting the usage data!

fyi @derekwaynecarr @alvaroaleman @jeremyeder

https://issues.redhat.com/browse/SDN-3132

@openshift-ci openshift-ci bot requested review from dcbw and dougbtv June 9, 2022 16:00
@dcbw
Copy link
Contributor

dcbw commented Jun 9, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 9, 2022
@sjenning
Copy link
Contributor Author

sjenning commented Jun 9, 2022

/retest-required

@zshi-redhat
Copy link
Contributor

/lgtm

@zshi-redhat
Copy link
Contributor

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, sjenning, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alvaroaleman
Copy link
Contributor

/retest-required

1 similar comment
@sjenning
Copy link
Contributor Author

/retest-required

@sjenning sjenning changed the title bindata: managed: reduce memory requests to align with observed usage Bug 2095772: bindata: managed: reduce memory requests to align with observed usage Jun 10, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

@sjenning: This pull request references Bugzilla bug 2095772, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2095772: bindata: managed: reduce memory requests to align with observed usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 10, 2022

@sjenning: This pull request references Bugzilla bug 2095772, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 337cf37 and 8 for PR HEAD 3eb4e1b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 337cf37 and 7 for PR HEAD 3eb4e1b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 337cf37 and 6 for PR HEAD 3eb4e1b in total

@alvaroaleman
Copy link
Contributor

/retest-required

2 similar comments
@alvaroaleman
Copy link
Contributor

/retest-required

@sjenning
Copy link
Contributor Author

/retest-required

@sjenning
Copy link
Contributor Author

metal-ipi-ovn-ipv6 has a very low pass rate
https://prow.ci.openshift.org/?job=pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-ipv6
https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-openshift-cluster-network-operator-master-e2e-metal-ipi-ovn-ipv6

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD f1a70e4 and 5 for PR HEAD 3eb4e1b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD f1a70e4 and 4 for PR HEAD 3eb4e1b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f1a70e4 and 3 for PR HEAD 3eb4e1b in total

@sjenning
Copy link
Contributor Author

/retest-required

1 similar comment
@sjenning
Copy link
Contributor Author

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2022 •
edited

@sjenning: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6-ipsec 3eb4e1b link false /test e2e-metal-ipi-ovn-ipv6-ipsec
ci/prow/e2e-aws-ovn-windows 3eb4e1b link false /test e2e-aws-ovn-windows
ci/prow/e2e-azure-ovn 3eb4e1b link false /test e2e-azure-ovn
ci/prow/e2e-openstack-ovn 3eb4e1b link false /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sjenning
Copy link
Contributor Author

/test e2e-network-migration

@openshift-ci openshift-ci bot merged commit 969bc4f into openshift:master Jun 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

@sjenning: All pull requests linked via external trackers have merged:

Bugzilla bug 2095772 has been moved to the MODIFIED state.

In response to this:

Bug 2095772: bindata: managed: reduce memory requests to align with observed usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sjenning
Copy link
Contributor Author

also https://issues.redhat.com/browse/HOSTEDCP-481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@dougbtv dougbtv Awaiting requested review from dougbtv

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@zshi-redhat zshi-redhat

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sjenning @dcbw @zshi-redhat @alvaroaleman @openshift-ci-robot