Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.5]Bug 1880341: update client-go to fix reflector not recovering from "Too large resource version" #807

Conversation

JacobTanenbaum
Copy link
Contributor

cherrypicking as much as I can to bring in the right vendored code and changes required to update k8s dependencies to 0.18.6

vishnoianil and others added 6 commits September 25, 2020 08:44
    Modules is an official dependency management system
    starting from v1.14. This new dependency management
    system was introduced in go version 1.11. To build
    current code in go 1.14, you need to explictly set
    GO111MODULE to off, so that it can pickup the legacy dep
    management system.
    I migrated the code to Modules based on the best practices
    suggested in the following links from kubernetes community.
    Please refer these urls for more details.

*.* https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/2019-03-19-go-modules.md#motivation
*.* https://github.com/golang/go/wiki/Modules#how-do-i-use-vendoring-with-modules-is-vendoring-going-away
*.* https://tip.golang.org/cmd/go/#hdr-Modules_and_vendoring

Signed-off-by: Anil Vishnoi <avishnoi@redhat.com>
took the updates to the api from 8fccb9e
and ran `go mod vendor` and `go mod tidy`
removed the ipv6 test from the cherry-pick
This commit makes iptables commands available on the
Kuryr CNI container by relying on the host.
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 25, 2020
@openshift-ci-robot
Copy link
Contributor

@JacobTanenbaum: This pull request references Bugzilla bug 1880341, which is invalid:

  • expected dependent Bugzilla bug 1882071 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1880341: update client-go to fix reflector not recovering from "Too large resource version"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 25, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JacobTanenbaum
To complete the pull request process, please assign abhat
You can assign the PR to them by writing /assign @abhat in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JacobTanenbaum JacobTanenbaum changed the title Bug 1880341: update client-go to fix reflector not recovering from "Too large resource version" [release-4.5]Bug 1880341: update client-go to fix reflector not recovering from "Too large resource version" Sep 25, 2020
as much of a cherry-pick as I could
@openshift-ci-robot
Copy link
Contributor

@JacobTanenbaum: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/unit c3d41b5 link /test unit
ci/prow/verify c3d41b5 link /test verify
ci/prow/e2e-ovn-hybrid-step-registry c3d41b5 link /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-gcp c3d41b5 link /test e2e-gcp
ci/prow/e2e-metal-ipi c3d41b5 link /test e2e-metal-ipi
ci/prow/e2e-aws-sdn-single c3d41b5 link /test e2e-aws-sdn-single
ci/prow/e2e-ovn-step-registry c3d41b5 link /test e2e-ovn-step-registry
ci/prow/e2e-metal-ipi-ovn-ipv6 c3d41b5 link /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

@JacobTanenbaum: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-agnostic-upgrade c3d41b5 link /test e2e-agnostic-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2021
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 21, 2021
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants