-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.5]Bug 1880341: update client-go to fix reflector not recovering from "Too large resource version" #807
Conversation
Modules is an official dependency management system starting from v1.14. This new dependency management system was introduced in go version 1.11. To build current code in go 1.14, you need to explictly set GO111MODULE to off, so that it can pickup the legacy dep management system. I migrated the code to Modules based on the best practices suggested in the following links from kubernetes community. Please refer these urls for more details. *.* https://github.com/kubernetes/enhancements/blob/master/keps/sig-architecture/2019-03-19-go-modules.md#motivation *.* https://github.com/golang/go/wiki/Modules#how-do-i-use-vendoring-with-modules-is-vendoring-going-away *.* https://tip.golang.org/cmd/go/#hdr-Modules_and_vendoring Signed-off-by: Anil Vishnoi <avishnoi@redhat.com>
took the updates to the api from 8fccb9e and ran `go mod vendor` and `go mod tidy`
removed the ipv6 test from the cherry-pick
This commit makes iptables commands available on the Kuryr CNI container by relying on the host.
@JacobTanenbaum: This pull request references Bugzilla bug 1880341, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JacobTanenbaum The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
as much of a cherry-pick as I could
43b4f43
to
c3d41b5
Compare
@JacobTanenbaum: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@JacobTanenbaum: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cherrypicking as much as I can to bring in the right vendored code and changes required to update k8s dependencies to 0.18.6