extends shutdown delay duration to 10 seconds #442
Conversation
|
/assing @sttts @smarterclayton |
the general rule of thumb is to wait ~5s-10s for any service behind the service network. during that time the controllers should remove the endpoint from the pool and the applicaiton won't receive any new connections.
p0lyn0mial
force-pushed
the
extend-shutdown-delay-duration
branch
from
0cdca10
to
1c60322
Compare
p0lyn0mial
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/cherrypick release-4.7 |
|
@p0lyn0mial: once the present PR merges, I will cherry-pick it on top of release-4.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@p0lyn0mial: new pull request created: #445 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The general rule of thumb is to wait ~5s-10s for any service behind the service network.
During that time the controllers should remove the endpoint from the pool and the application won't receive any new connections.
xref: openshift/openshift-apiserver#198