Bug 1820687: use patch when updating namespace #22
Conversation
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@soltysh: This pull request references Bugzilla bug 1820687, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
approved
|
/retest |
|
@soltysh: This pull request references Bugzilla bug 1820687, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
soltysh
added
the
do-not-merge/hold
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
| @@ -178,7 +182,21 @@ func (c *NamespaceSCCAllocationController) allocate(ns *corev1.Namespace) error | |||
| } | |||
| } | |||
|
|
|||
| _, err = c.namespaceClient.Update(nsCopy) | |||
| encoder := legacyscheme.Codecs.LegacyCodec(legacyscheme.Scheme.PrioritizedVersionsAllGroups()...) | |||
There was a problem hiding this comment.
install the core types into a scheme to do this. You want to snip k/k links, not create them.
|
just the note about the scheme, then lgtm /cherrypick release-4.4 |
|
@deads2k: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -54,6 +60,13 @@ func NewNamespaceSCCAllocationController( | |||
| requiredUIDRange *uid.Range, | |||
| mcs MCSAllocationFunc, | |||
| ) *NamespaceSCCAllocationController { | |||
|
|
|||
| scheme := runtime.NewScheme() | |||
There was a problem hiding this comment.
you can do all this in an init block and have the encoder as a package var
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@soltysh: All pull requests linked via external trackers have merged: openshift/cluster-kube-controller-manager-operator#394, openshift/cluster-policy-controller#22, openshift/origin#24828. Bugzilla bug 1820687 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@deads2k: new pull request created: #24 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @deads2k
Requires openshift/cluster-kube-controller-manager-operator#394
/hold