runs OpenShift specific ResourceQuota monitors #44
Conversation
|
/assign @deads2k |
|
/assing @soltysh |
pkg/cmd/controller/quota.go
Outdated
| } | ||
| if evaluator := registry.Get(gr); evaluator != nil { | ||
| interestingResources = append(interestingResources, resourceList) | ||
| break |
There was a problem hiding this comment.
maybe we should remove it, what if more resources in the group apply?
openshift-ci-robot
added
lgtm
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
for backward compatability we need to maintain "openshift.io/imagestreams" alias for "count/imagestreams.image.openshift.io" to dynamically update quota for imagestreams resources.
openshift-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.6 |
|
@p0lyn0mial: new pull request created: #45 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
for backward compatability we need to maintain "openshift.io/imagestreams" alias for "count/imagestreams.image.openshift.io"
to dynamically update quota for imagestreams resources.