Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

an e2e for testing "openshift.io/imagestreams" count quota #25645

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

p0lyn0mial
Copy link
Contributor

For backward compatibility we need to maintain openshift.io/imagestreams alias for count/imagestreams.image.openshift.io. This pr adds an e2e test for counting imagestreams resources.

for backward compatability we need to maintain "openshift.io/imagestreams" alias for "count/imagestreams.image.openshift.io".
this pr adds an e2e test for counting imagestreams resources.
@p0lyn0mial
Copy link
Contributor Author

/assign @soltysh

@p0lyn0mial
Copy link
Contributor Author

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2020
@openshift-merge-robot openshift-merge-robot merged commit 8768214 into openshift:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants