status: Generation should be set by what the sync worker is doing #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
approved
|
8ea7884 is a good catch. /approve do you want to wait for https://github.com/openshift/api/pull/185/files and bring that in as vendor update ? |
|
Yes (that's where I caught this) |
openshift-ci-robot
added
needs-rebase
The primary mechanism where by a reconciling controller communicates to a client is its status, and the client has to wait until the controller observes its write before assuming the controller is ready. When writing a client that is triggering an upgrade, we need to: 1. Set desiredUpdate and read resulting generation 2. Wait until status.generation == generation from 1 3. Wait until the update that is marked partial in status history is complete This fixes the sync worker to be the one who propagates generation, so that a client doesn't see 2 above when syncing a previous generation.
smarterclayton
force-pushed
the
generation
branch
from
b0e1b15
to
a703c2e
Compare
openshift-ci-robot
added
size/L
|
Rebased and updated with new api |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary mechanism where by a reconciling controller communicates to a client is its status, and the client has to wait until the controller observes its write before assuming the controller is ready.
When writing a client that is triggering an upgrade, we need to:
This fixes the sync worker to be the one who propagates generation, so that a client doesn't see 2 as true when syncing a previous generation.