Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

status: Generation should be set by what the sync worker is doing #102

Merged
merged 3 commits into from
Jan 28, 2019
Merged

status: Generation should be set by what the sync worker is doing #102

merged 3 commits into from
Jan 28, 2019

Commits on Jan 28, 2019

  1. status: Generation should be set by what the sync worker is doing 

    The primary mechanism where by a reconciling controller communicates
to a client is its status, and the client has to wait until the
controller observes its write before assuming the controller is ready.

When writing a client that is triggering an upgrade, we need to:

1. Set desiredUpdate and read resulting generation
2. Wait until status.generation == generation from 1
3. Wait until the update that is marked partial in status history is complete

This fixes the sync worker to be the one who propagates generation, so
that a client doesn't see 2 above when syncing a previous generation.
    @smarterclayton
    smarterclayton committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    d7d777b View commit details
    Browse the repository at this point in the history

  2. vendor: Update openshift/api for ObservedGeneration

    @smarterclayton
    smarterclayton committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    f35e3f8 View commit details
    Browse the repository at this point in the history

  3. cvo: Update to use ObservedGeneration after API bump

    @smarterclayton
    smarterclayton committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    a703c2e View commit details
    Browse the repository at this point in the history