-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync: Report a specific cluster operator error when not available #110
Conversation
/assign @abhinavdahiya |
Flake is #111 |
026db24
to
f508897
Compare
Comments addressed |
/retest |
f508897
to
dcc1e90
Compare
/lgtm |
/test all |
/refresh |
/test e2e-aws |
Cluster operators block most of upgrade, so we should report the information the cluster operator has available back to the CV status object via an UpdateError. Reduce the amount of debug info printed by cluster operator status waiting to simplify the logs. While reviewing CV logs from startup, we run the resync loop more frequently waiting for the CO to be created because we exit the poll loop on any error. When we see "CO not found", continue the loop to avoid going back and syncing on top. Finally, remove the apiVersion info from the status log message, it didn't make much sense and the end user is going to have to look at the payload anyway if we get into a wierd error case where it matters (the apiVersion was put in in case we had to debug a typo in a version, which really shouldn't happen).
dcc1e90
to
8eb6764
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
/test images |
1 similar comment
/test images |
/refresh |
/test all |
Trivial rebase, reapplying label |
/retest |
Cluster operators block most of upgrade, so we should report the information the cluster operator has available back to the CV status object via an UpdateError.
Reduce the amount of debug info printed by cluster operator status waiting to simplify the logs.
While reviewing CV logs from startup, we run the resync loop more frequently waiting for the CO to be created because we exit the poll loop on any error. When we see "CO not found", continue the loop to avoid triggering the top level sync worker backoff loop. Shaves a few tens of seconds of startup time.
Finally, remove the apiVersion info from the status log message, it didn't make much sense and the end user is going to have to look at the payload anyway if we get into a wierd error case where it matters (the apiVersion was put in in case we had to debug a typo in a version, which really shouldn't happen).