sync: Report a specific cluster operator error when not available #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/M
|
/assign @abhinavdahiya |
|
Flake is #111 |
smarterclayton
force-pushed
the
status
branch
2 times, most recently
from
026db24
to
f508897
Compare
|
Comments addressed |
|
/retest |
smarterclayton
force-pushed
the
status
branch
from
f508897
to
dcc1e90
Compare
|
/lgtm |
|
/test all |
|
/refresh |
|
/test e2e-aws |
Cluster operators block most of upgrade, so we should report the information the cluster operator has available back to the CV status object via an UpdateError. Reduce the amount of debug info printed by cluster operator status waiting to simplify the logs. While reviewing CV logs from startup, we run the resync loop more frequently waiting for the CO to be created because we exit the poll loop on any error. When we see "CO not found", continue the loop to avoid going back and syncing on top. Finally, remove the apiVersion info from the status log message, it didn't make much sense and the end user is going to have to look at the payload anyway if we get into a wierd error case where it matters (the apiVersion was put in in case we had to debug a typo in a version, which really shouldn't happen).
smarterclayton
force-pushed
the
status
branch
from
dcc1e90
to
8eb6764
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
|
/test images |
1 similar comment
|
/test images |
|
/refresh |
|
/test all |
|
Trivial rebase, reapplying label |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster operators block most of upgrade, so we should report the information the cluster operator has available back to the CV status object via an UpdateError.
Reduce the amount of debug info printed by cluster operator status waiting to simplify the logs.
While reviewing CV logs from startup, we run the resync loop more frequently waiting for the CO to be created because we exit the poll loop on any error. When we see "CO not found", continue the loop to avoid triggering the top level sync worker backoff loop. Shaves a few tens of seconds of startup time.
Finally, remove the apiVersion info from the status log message, it didn't make much sense and the end user is going to have to look at the payload anyway if we get into a wierd error case where it matters (the apiVersion was put in in case we had to debug a typo in a version, which really shouldn't happen).