Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating .ci-operator.yaml build_root_image from openshift/release #608

Conversation

openshift-ci-robot
Copy link
Contributor

This is an autogenerated PR that updates the .ci-operator.yaml
to reference the build_root_image found in the ci-operator-config
in the openshift/release repository.

This is done in preparation for enabling reading the build_root from
your repository rather than the central config in openshift/release.
This allows to update the build_root in lockstep with code changes. For details, please
refer to the docs.

Note that enabling this feature is mandatory for all OCP components that have an ART build config.

A second autogenerated PR to the openshift/release repository
will enable reading the build_root from your repository once this PR was merged.

If you have any questions, please feel free to reach out in the #forum-testplatform
channel in the CoreOS Slack.
/cc @

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jun 14, 2021
@openshift-ci openshift-ci bot requested review from crawford and sdodson June 14, 2021 23:28
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-ci-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-ci-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Jun 15, 2021

pods should successfully create sandboxes by other is unrelated.

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade

In response to this:

pods should successfully create sandboxes by other is unrelated.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking
Copy link
Member

wking commented Jun 15, 2021

TestCVO_UpgradeUnverifiedPayload race is unrelated.

/override ci/prow/unit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@wking: Overrode contexts on behalf of wking: ci/prow/unit

In response to this:

TestCVO_UpgradeUnverifiedPayload race is unrelated.

/override ci/prow/unit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot force-pushed the updating-.ci-operator.yaml-`build_root_image`-from-openshift/release branch from 26be365 to d5eb87a Compare June 15, 2021 05:04
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
This is an autogenerated PR that updates the `.ci-operator.yaml`
to reference the `build_root_image` found in the [ci-operator-config](https://github.com/openshift/release/tree/master/ci-operator/config)
in the [openshift/release](https://github.com/openshift/release) repository.

This is done in preparation for enabling reading the `build_root` from
your repository rather than the central config in [openshift/release](https://github.com/openshift/release).
This allows to update the `build_root` in lockstep with code changes. For details, please
refer to the [docs](https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).

Note that enabling this feature is mandatory for all OCP components that have an ART build config.

A second autogenerated PR to the [openshift/release repository](https://github.com/openshift/release)
will enable reading the `build_root` from your repository once this PR was merged.

If you have any questions, please feel free to reach out in the #forum-testplatform
channel in the CoreOS Slack.
@openshift-ci-robot openshift-ci-robot force-pushed the updating-.ci-operator.yaml-`build_root_image`-from-openshift/release branch from d5eb87a to c58f208 Compare June 15, 2021 08:04
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@wking
Copy link
Member

wking commented Jun 15, 2021

Build time config could not possibly impact updates.

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2021

@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade

In response to this:

Build time config could not possibly impact updates.

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking merged commit 8122b01 into openshift:master Jun 15, 2021
@wking
Copy link
Member

wking commented Jun 15, 2021

All green, flake rate is high, so Prow's batch jobs are unlikely to pass. Merging by hand to clear out our PR backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants