Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more golangci-lint issues #616

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Fix more golangci-lint issues #616

merged 1 commit into from
Jun 25, 2021

Conversation

arjunrn
Copy link
Contributor

@arjunrn arjunrn commented Jun 24, 2021 •
edited
Loading

Fixed linting issues with redundant type declaration and the use of fmt.Sprintf() when there is no string formatting required.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2021
@arjunrn
Fix more golangci-lint issues
ce3ca6f 
Fixed linting issues with redundant type declaration and the use of
fmt.Sprintf when there is no string formatting required.
@arjunrn arjunrn changed the title [WIP] Run golangci-lint with verbose logging Run golangci-lint with verbose logging Jun 25, 2021
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2021
@arjunrn arjunrn changed the title Run golangci-lint with verbose logging Fix more golangci-lint issues Jun 25, 2021
@arjunrn
Copy link
Contributor Author

arjunrn commented Jun 25, 2021

/assign @LalatenduMohanty

@arjunrn arjunrn mentioned this pull request Jun 25, 2021
Merged
LalatenduMohanty
LalatenduMohanty approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 25, 2021
vrutkovs
vrutkovs approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vrutkovs
Copy link
Member

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arjunrn, LalatenduMohanty, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-agnostic-upgrade

In response to this:

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LalatenduMohanty
Copy link
Member

/override ci/prow/e2e-agnostic-upgrade

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 25, 2021

@LalatenduMohanty: Overrode contexts on behalf of LalatenduMohanty: ci/prow/e2e-agnostic-upgrade

In response to this:

/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit e1adca4 into openshift:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@vrutkovs vrutkovs

@LalatenduMohanty LalatenduMohanty

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arjunrn @vrutkovs @LalatenduMohanty @openshift-merge-robot