Bug 2011951: pkg/cvo/upgradeable: Include messages for multiple-reason Upgradeable=False #671
Conversation
…=False
Because:
Upgradeable=False
Reason: MultipleReasons
Message: Cluster cannot be upgraded between minor versions for multiple reasons: AdminAckRequired,IncompatibleOperatorsInstalled
doesn't include all the useful information needed to resolve those
issues. This pivots to using the same approach we use today when
aggregating multiple Upgradeable=False ClusterOperators.
Also shift the patch-blocking overrides check in front of the other
minor blocking checks. It's more important (because it blocks more
targets), and it also will not included a nested sub-list (which might
be confusing, because today I'm not adding indents or any such markers
to make it easy to distinguish levels in a nested list hierarchy).
openshift-ci
bot
added
bugzilla/severity-urgent
|
@wking: This pull request references Bugzilla bug 2011951, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
…=False
Because:
Upgradeable=False
Reason: MultipleReasons
Message: Cluster cannot be upgraded between minor versions for multiple reasons: AdminAckRequired,IncompatibleOperatorsInstalled
doesn't include all the useful information needed to resolve those
issues. This pivots to using the same approach we use today when
aggregating multiple Upgradeable=False ClusterOperators.
Also shift the patch-blocking overrides check in front of the other
minor blocking checks. It's more important (because it blocks more
targets), and it also will not included a nested sub-list (which might
be confusing, because today I'm not adding indents or any such markers
to make it easy to distinguish levels in a nested list hierarchy).
This cherry-picks 0c742e5 (pkg/cvo/upgradeable: Include messages
for multiple-reason Upgradeable=False, 2021-10-07, openshift#671) back to 4.8,
with a minor context change because 4.8 doesn't have 0afb8a8 (Add a
manifest annotation to be used for object deletion, 2020-08-17, openshift#438).
…=False
Because:
Upgradeable=False
Reason: MultipleReasons
Message: Cluster cannot be upgraded between minor versions for multiple reasons: AdminAckRequired,IncompatibleOperatorsInstalled
doesn't include all the useful information needed to resolve those
issues. This pivots to using the same approach we use today when
aggregating multiple Upgradeable=False ClusterOperators.
Also shift the patch-blocking overrides check in front of the other
minor blocking checks. It's more important (because it blocks more
targets), and it also will not included a nested sub-list (which might
be confusing, because today I'm not adding indents or any such markers
to make it easy to distinguish levels in a nested list hierarchy).
This cherry-picks 0c742e5 (pkg/cvo/upgradeable: Include messages
for multiple-reason Upgradeable=False, 2021-10-07, openshift#671) back to 4.8,
with a minor context change because 4.8 doesn't have 0afb8a8 (Add a
manifest annotation to be used for object deletion, 2020-08-17, openshift#438).
|
/bugzilla refresh |
|
@wking: This pull request references Bugzilla bug 2011951, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/valid-bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sdodson
added
the
staff-eng-approved
|
This is not a blocker but it's a downward bound UX improvement that we'd like to get into 4.8 ASAP, adding staff-engineer-approved label. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
Sandbox and Watchdog issues are unrelated: /override ci/prow/e2e-agnostic-upgrade |
|
@wking: Overrode contexts on behalf of wking: ci/prow/e2e-agnostic-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: All pull requests linked via external trackers have merged: Bugzilla bug 2011951 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
wking
deleted the
include-messages-in-multi-reason-upgradeable-message-4.9
branch
Backporting #670 to 4.9.