-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2007328: Updated patternfly to v4.125.3 and pf.quickstarts to v1.2.3. #10090
Bug 2007328: Updated patternfly to v4.125.3 and pf.quickstarts to v1.2.3. #10090
Conversation
Unfortunately, we're in a tough spot given the size of our code base. Updating the types creates thousands of type errors, which is why we haven't done it. We need to come up with a strategy for getting them bumped. I was hoping when we pull out dynamic plugins into separate repos it will make this more manageable. |
/retest |
e2abf64
to
3d4b750
Compare
/retest |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, jcaianirh, kdoberst The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dtaylor113: This pull request references Bugzilla bug 2007328, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dtaylor113: All pull requests linked via external trackers have merged: Bugzilla bug 2007328 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pretty standard update. One tweak in User Preferences, and another in QuickStarts.
The former sparked a discussion in PF asking when we (OpenShift) was going to update our 2 year old
@types/react
to the latest release:cc'ing @zherman0 who I thought did some recent React version updates in our codebase.