Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2007328: Updated patternfly to v4.125.3 and pf.quickstarts to v1.2.3. #10090

Merged

Conversation

dtaylor113
Copy link
Contributor

Pretty standard update. One tweak in User Preferences, and another in QuickStarts.

The former sparked a discussion in PF asking when we (OpenShift) was going to update our 2 year old @types/react to the latest release:

zack
@Nicole @Evan Wilkinson You may want to schedule a time with Sam to talk about their 2 year old 
@types/react@16.8.13 which causes their types to break whenever we change whether 
a component forwards its ref.

This is the 3rd release we've seen the translate type error occur when bumping PatternFly

cc'ing @zherman0 who I thought did some recent React version updates in our codebase.

@spadgett
Copy link
Member

The former sparked a discussion in PF asking when we (OpenShift) was going to update our 2 year old @types/react to the latest release:

Unfortunately, we're in a tough spot given the size of our code base. Updating the types creates thousands of type errors, which is why we haven't done it. We need to come up with a strategy for getting them bumped. I was hoping when we pull out dynamic plugins into separate repos it will make this more manageable.

cc @kdoberst @christianvogt

@dtaylor113
Copy link
Contributor Author

/retest

@dtaylor113
Copy link
Contributor Author

/retest

@jcaianirh
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2021
@kdoberst
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, jcaianirh, kdoberst

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2021
@dtaylor113 dtaylor113 changed the title Updated patternfly to v4.125.3 and pf.quickstarts to v1.2.3. Bug 2007328: Updated patternfly to v4.125.3 and pf.quickstarts to v1.2.3. Sep 23, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2021

@dtaylor113: This pull request references Bugzilla bug 2007328, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

Bug 2007328: Updated patternfly to v4.125.3 and pf.quickstarts to v1.2.3.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from yapei September 23, 2021 15:12
@openshift openshift deleted a comment from openshift-ci bot Sep 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit 1e297f1 into openshift:master Sep 23, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 23, 2021

@dtaylor113: All pull requests linked via external trackers have merged:

Bugzilla bug 2007328 has been moved to the MODIFIED state.

In response to this:

Bug 2007328: Updated patternfly to v4.125.3 and pf.quickstarts to v1.2.3.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.10 milestone Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/topology Related to topology lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants